migration file does not display error

[samirhembrom]

Should this code throw error? I applied the migration, goose displays that the migration was applied but when i see the database the table was not created.
`-- +goose Up
CREATE TABLE users (
id UUID PRIMARY KEY,
created_at TIMESTAMP NOT NULL,
updated_at TIMESTAMP NOT NULL,
email TEXT NOT NULL UNIQUE
);

-- -goose Down
DROP TABLE users;
`

[mfridman]

What's wrong with this migration? Seems fine to me.

Is it possible you're checking the wrong database (or more likely, the wrong schema) from where the migration was applied?

[samirhembrom]

-- -goose Down
The negative sign ? is it ok?

[mfridman]

Ah, no that's not okay. We don't have any heuristics around malformed goose annotations. And also, the down migration is optional, so this ends up creating and dropping the table in the same migration 🙈

I think we can improve this by best effort detecting -- .. goose .. and failing outright to avoid issues like this.

[samirhembrom]

Even I had difficulty finding the subtle difference there. Goose did show me it applied the migrations but the table was not showing up. So this was creating the table but also dropping the table.😲 Now I get it.