-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
Awaiting Maintainer ApprovalNeeds review from a maintainer before moving forwardNeeds review from a maintainer before moving forwardBugError or unexpected behaviorsError or unexpected behaviors
Description
p5.js version
No response
What is your operating system?
None
Web browser and version
No response
Actual Behavior
I ran npm run test and the tests all passed ✅ …but the console threw up this React unsafe lifecycle warning
It’s complaining about componentWillMount being deprecated and suggesting migration to UNSAFE_componentWillMount or moving logic into componentDidMount. The warning points to SideEffect(NullComponent) as the culprit.
So while the tests are green, the warning is a reminder that we’ve got some legacy lifecycle methods lurking in the codebase that could cause trouble down the line.

Expected Behavior
It should pass all the Test cases without throwing any warning specially not unsafe one.
Steps to reproduce
Steps:
- clone this repository
- run
npm install - run
npm run test
Snippet:
// Paste your code here :)Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Awaiting Maintainer ApprovalNeeds review from a maintainer before moving forwardNeeds review from a maintainer before moving forwardBugError or unexpected behaviorsError or unexpected behaviors