WebGL ShapeBuilder doesn't support mixed shape modes in contours

[avinxshKD]

Increasing access

Increasing access

Fixes potential rendering bugs when mixing different shape modes within the same shape.

Most appropriate sub-area of p5.js?
WebGL
Feature enhancement details
Found this while looking through the ShapeBuilder code - it assumes all contours in a shape use the same rendering mode.

In ShapeBuilder.js line 54, it just grabs the mode from the first contour:

// TODO: handle just some contours having non-PATH mode
this.shapeMode = shape.contours[0].kind;

So if someone creates a shape where:

• First contour uses POINTS

• Second contour uses LINES

• Third contour uses TRIANGLES

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• WebGL
• Build process
• Unit testing
• Internationalization
• Friendly errors
• Other (specify if possible)

Feature enhancement details

Everything gets rendered as POINTS since that's what the first contour was.

There's another TODO around line 260 in the edge processing that mentions the same limitation.

Not sure how often people actually mix modes like this, but it could definitely cause weird rendering issues. Would probably need to process each contour according to its own mode instead of using the first one for everything

[avinxshKD]

Ready to go, Just let me know Thanks

[davepagurek]

How would you imagine the user-facing API would look? e.g. if a user were to draw a shape with the three contours in your issue description, what would their p5 code look like to accomplish that?

[avinxshKD]

@davepagurek Hmm good point. Looking at it again, beginShape() already takes the mode,, so there's no way to set different modes per contour in the current API anyway.

The TODO might just be documenting a design choice rather than something that needs fixing.

Should I close this one? or is there actually a legitimate use case I'm missing here?