Skip to content

Commit a4f6928

Browse files
Fixing manifest icon image fallback
1 parent 38eaafd commit a4f6928

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

apps/pwabuilder-google-play/services/packageCreator.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class PackageCreator {
9191

9292
// Get the signing information.
9393
this.dispatchProgressEvent(`Creating signing information...`);
94-
const signing = await this.createLocalSigninKeyInfo(options, projectDirPath);
94+
const signing = await this.createLocalSigningKeyInfo(options, projectDirPath);
9595

9696
// Generate the APK, keys, and digital asset links.
9797
return await this.createAppPackageWith403Fallback(
@@ -169,7 +169,7 @@ export class PackageCreator {
169169
}
170170
}
171171

172-
private async createLocalSigninKeyInfo(apkSettings: AndroidPackageOptions, projectDir: string): Promise<LocalKeyFileSigningOptions | null> {
172+
private async createLocalSigningKeyInfo(apkSettings: AndroidPackageOptions, projectDir: string): Promise<LocalKeyFileSigningOptions | null> {
173173
// If we're told not to sign it, skip this.
174174
if (apkSettings.signingMode === 'none') {
175175
return null;

components/manifest-editor/src/components/manifest-icons-form.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ export class ManifestIconsForm extends LitElement {
604604
}
605605

606606
renderIcon(i: Icon): TemplateResult {
607-
const crossDomainFallbackUrl = `${this.imageProxyUrl}?url=${encodeURIComponent(i.src)}&analysisId=${this.analysisId}`;
607+
const crossDomainFallbackUrl = `${this.imageProxyUrl}?imageUrl=${encodeURIComponent(i.src)}&analysisId=${this.analysisId}`;
608608
return html`
609609
<div class="icon-box">
610610
<img class="icon" src=${i.src}

0 commit comments

Comments
 (0)