fixed impl. for asymmetric two roll pass for basic tests.

Author: Christoph Renzing

pyroll/core/__init__.py

@@ -27,7 +27,7 @@
     create_groove_by_type_name,
 )
 from .transport import Transport, CoolingPipe
-from .roll_pass import BaseRollPass, DeformationUnit, ThreeRollPass, SymmetricRollPass, TwoRollPass
+from .roll_pass import BaseRollPass, DeformationUnit, ThreeRollPass, SymmetricRollPass, TwoRollPass, AsymmetricTwoRollPass
 from .roll_pass import TwoRollPass as RollPass
 from .unit import Unit
 from .roll import Roll

pyroll/core/roll_pass/__init__.py

@@ -13,4 +13,5 @@
     "ThreeRollPass",
     "DeformationUnit",
     "SymmetricRollPass",
+    "AsymmetricTwoRollPass"
 ]

pyroll/core/roll_pass/asymmetric_two_roll_pass.py

@@ -3,32 +3,37 @@
 import numpy as np
 from shapely.affinity import translate, scale
 from shapely.geometry import LineString
+from shapely.geometry.multilinestring import MultiLineString
 
 from .base import BaseRollPass
 from ..hooks import Hook
 from ..roll import Roll as BaseRoll
-
+from ..engine import Engine as BaseEngine
 
 class AsymmetricTwoRollPass(BaseRollPass):
-    """Represents a symmetric roll pass with equal upper and lower working roll."""
+    """Represents a symmetric roll pass with unequal upper and lower roll."""
 
     def __init__(
             self,
             upper_roll: BaseRoll,
             lower_roll: BaseRoll,
+            engine: BaseEngine = BaseEngine(),
             label: str = "",
             **kwargs
     ):
         super().__init__(label, **kwargs)
 
         self.upper_roll = self.Roll(upper_roll, self)
-        """The upper working roll of this pass."""
+        """The upper roll of this pass."""
 
         self.lower_roll = self.Roll(lower_roll, self)
-        """The upper working roll of this pass."""
+        """The lower roll of this pass."""
+
+        self.engine = self.Engine(engine, self)
+        """The engine of this pass."""
 
     @property
-    def contour_lines(self) -> List[LineString]:
+    def contour_lines(self) -> MultiLineString:
         if self._contour_lines:
             return self._contour_lines
 
@@ -38,7 +43,7 @@ def contour_lines(self) -> List[LineString]:
             xfact=1, yfact=-1, origin=(0, 0)
         )
 
-        self._contour_lines = [upper, lower]
+        self._contour_lines = MultiLineString([upper, lower])
         return self._contour_lines
 
     @property

pyroll/core/roll_pass/base.py

@@ -135,7 +135,7 @@ def init_solve(self, in_profile: BaseProfile):
 
     def reevaluate_cache(self):
         super().reevaluate_cache()
-        self.roll.reevaluate_cache()
+        #self.roll.reevaluate_cache()
         self._contour_lines = None
         self.engine.reevaluate_cache()
 

pyroll/core/roll_pass/hookimpls/asymmetric_two_roll_pass.py

@@ -103,7 +103,7 @@ def pass_line(self: AsymmetricTwoRollPass.InProfile) -> tuple[float, float, floa
         x_guess, y_guess, _ = self.pass_line
 
     def contact_objective(xy):
-        shifted_cross_section = shapely.affinity.translate(rp.rotated_in_profile.cross_section, yoff=xy[1])
+        shifted_cross_section = shapely.affinity.translate(rp.in_profile.cross_section, yoff=xy[1])
 
         upper_contour = shapely.geometry.LineString(np.stack([
             rp.upper_roll.surface_z,
@@ -131,7 +131,7 @@ def contact_objective(xy):
 
 @AsymmetricTwoRollPass.InProfile.cross_section
 def in_cross_section(self:AsymmetricTwoRollPass.InProfile):
-    return shapely.affinity.translate(self.roll_pass.rotated_in_profile.cross_section, xoff=self.pass_line[2], yoff=self.pass_line[1])
+    return shapely.affinity.translate(self.roll_pass.in_profile.cross_section, xoff=self.pass_line[2], yoff=self.pass_line[1])
 
 
 @AsymmetricTwoRollPass.entry_point

pyroll/core/roll_pass/hookimpls/helpers.py

@@ -1,16 +1,16 @@
 import math
 
 import numpy as np
+import shapely
 from shapely import Polygon, clip_by_rect
 from shapely.affinity import rotate
 
 from ..two_roll_pass import TwoRollPass
 from ..three_roll_pass import ThreeRollPass
-from ..asymmetric_two_roll_pass import AsymmetricTwoRollPass
 from ...profile.profile import refine_cross_section
 
 
-def out_cross_section(rp: TwoRollPass | AsymmetricTwoRollPass, width: float) -> Polygon:
+def out_cross_section(rp: TwoRollPass, width: float) -> Polygon:
     poly = Polygon(np.concatenate([cl.coords for cl in rp.contour_lines.geoms]))
     poly = clip_by_rect(poly, -width / 2, -math.inf, width / 2, math.inf)
     return refine_cross_section(poly)

pyroll/core/roll_pass/hookimpls/profile.py

@@ -68,6 +68,15 @@ def cross_section_error(self: BaseRollPass.OutProfile):
 def cross_section(self: BaseRollPass.OutProfile) -> Polygon:
     in_profile_width = self.roll_pass.in_profile.width
 
+    if "asymmetric" in self.roll_pass.classifiers:
+        cs = helpers.out_cross_section(self.roll_pass, self.width)
+        if cs.width * 1.01 < self.width:
+            raise ValueError(
+                "Profile's width can not be larger than its contour lines."
+                "May be caused by critical overfilling."
+            )
+        return cs
+
     if "square" in self.roll_pass.in_profile.classifiers:
         horizontal_line = LineString([(-self.roll_pass.in_profile.width, 0), (self.roll_pass.in_profile.width, 0)])
         intersection_at_y0 = self.roll_pass.in_profile.cross_section.intersection(horizontal_line)