Commit fd0adb6
Reverts the addition of
… (introduced in #17300) which broke 8 quantization tests.
After #17300 merged, the following tests started failing:
- `test_shared_qspec_quantizer[input_fork_x_shared]`
- `test_shared_qspec_quantizer[input_fork_y_shared]`
- `test_shared_qspec_quantizer[surrounded_quantized_op]`
- `test_shared_qspec_quantizer[output_fork_shared]`
- `test_shared_qspec_quantizer[many_forks]`
- `test_dialect_mv2[mobilenet_v2]` (+ 2 more)
`RemoveNoopPass` removes `clone_dim_order` operators that are
functionally necessary for shared quantization specs. It only checks
dtype equality, not dim_order/layout changes, causing it to incorrectly
remove clones needed for:
- Tensor forking in quantized graphs
- Shared quantization parameter propagation
- Correct quantization fusion
Remove `RemoveNoopPass` from the Cortex-M pass pipeline. The MobileNetV2
`clone_dim_order` issue it was meant to address needs a more targeted
solution.
```bash
pytest -c backends/arm/test/pytest.ini backends/cortex_m/test/misc/test_quantization.py::test_shared_qspec_quantizer -v
pytest -c backends/arm/test/pytest.ini backends/cortex_m/test/models/test_mobilenet_v2.py::test_dialect_mv2 -v
Co-authored-by: Github Executorch <github_executorch@arm.com>RemoveNoopPass to the Cortex-M pass manager… (#17407)1 parent 29625e8 commit fd0adb6
File tree
2 files changed
+1
-2
lines changed- backends/cortex_m
- passes
- test/models
2 files changed
+1
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
35 | 34 | | |
36 | 35 | | |
37 | 36 | | |
38 | | - | |
39 | 37 | | |
40 | 38 | | |
41 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
0 commit comments