ci: test against a compatible connection_pool version (#706)

Author: santib

.github/workflows/build.yml

@@ -35,25 +35,17 @@ jobs:
           - dalli3
           - redis_5
           - redis_4
-          - connection_pool_dalli
           - active_support_8_1_redis_cache_store
-          - active_support_8_1_redis_cache_store_pooled
           - active_support_8_0_redis_cache_store
-          - active_support_8_0_redis_cache_store_pooled
           - active_support_7_2_redis_cache_store
-          - active_support_7_2_redis_cache_store_pooled
           - active_support_7_1_redis_cache_store
-          - active_support_7_1_redis_cache_store_pooled
           - active_support_7_0_redis_cache_store
-          - active_support_7_0_redis_cache_store_pooled
           - redis_store
         exclude:
           - gemfile: rails_7_0
             ruby: '3.4'
           - gemfile: active_support_7_0_redis_cache_store
             ruby: '3.4'
-          - gemfile: active_support_7_0_redis_cache_store_pooled
-            ruby: '3.4'
           - gemfile: rails_7_2
             ruby: '3.0'
           - gemfile: rails_7_2
@@ -62,10 +54,6 @@ jobs:
             ruby: '3.0'
           - gemfile: active_support_7_2_redis_cache_store
             ruby: '2.7'
-          - gemfile: active_support_7_2_redis_cache_store_pooled
-            ruby: '3.0'
-          - gemfile: active_support_7_2_redis_cache_store_pooled
-            ruby: '2.7'
           - gemfile: rails_8_0
             ruby: '3.1'
           - gemfile: rails_8_0
@@ -78,12 +66,6 @@ jobs:
             ruby: '3.0'
           - gemfile: active_support_8_0_redis_cache_store
             ruby: '2.7'
-          - gemfile: active_support_8_0_redis_cache_store_pooled
-            ruby: '3.1'
-          - gemfile: active_support_8_0_redis_cache_store_pooled
-            ruby: '3.0'
-          - gemfile: active_support_8_0_redis_cache_store_pooled
-            ruby: '2.7'
           - gemfile: rails_8_1
             ruby: '3.1'
           - gemfile: rails_8_1
@@ -96,12 +78,6 @@ jobs:
             ruby: '3.0'
           - gemfile: active_support_8_1_redis_cache_store
             ruby: '2.7'
-          - gemfile: active_support_8_1_redis_cache_store_pooled
-            ruby: '3.1'
-          - gemfile: active_support_8_1_redis_cache_store_pooled
-            ruby: '3.0'
-          - gemfile: active_support_8_1_redis_cache_store_pooled
-            ruby: '2.7'
     env:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
     steps:

Appraisals

@@ -8,98 +8,63 @@ appraise "rack_2" do
   gem "rack", "~> 2.0"
 end
 
-appraise 'rails_8-1' do
-  gem 'railties', '~> 8.1.0'
+appraise "rails_8-1" do
+  gem "railties", "~> 8.1.0"
 end
 
-appraise 'rails_8-0' do
-  gem 'railties', '~> 8.0.0'
+appraise "rails_8-0" do
+  gem "railties", "~> 8.0.0"
 end
 
-appraise 'rails_7-2' do
-  gem 'railties', '~> 7.2.0'
+appraise "rails_7-2" do
+  gem "railties", "~> 7.2.0"
 end
 
-appraise 'rails_7-1' do
-  gem 'railties', '~> 7.1.0'
+appraise "rails_7-1" do
+  gem "railties", "~> 7.1.0"
 end
 
-appraise 'rails_7-0' do
-  gem 'railties', '~> 7.0.0'
+appraise "rails_7-0" do
+  gem "railties", "~> 7.0.0"
 end
 
-appraise 'dalli3' do
-  gem 'dalli', '~> 3.0'
+appraise "dalli3" do
+  gem "dalli", "~> 3.0"
 end
 
-appraise 'redis_5' do
-  gem 'redis', '~> 5.0'
+appraise "redis_5" do
+  gem "redis", "~> 5.0"
 end
 
-appraise 'redis_4' do
-  gem 'redis', '~> 4.0'
-end
-
-appraise "connection_pool_dalli" do
-  gem "connection_pool", "~> 2.2"
-  gem "dalli", "~> 3.0"
+appraise "redis_4" do
+  gem "redis", "~> 4.0"
 end
 
 appraise "active_support_8-1_redis_cache_store" do
   gem "activesupport", "~> 8.1.0"
   gem "redis", "~> 5.0"
 end
 
-appraise "active_support_8-1_redis_cache_store_pooled" do
-  gem "activesupport", "~> 8.1.0"
-  gem "connection_pool", "~> 2.2"
-  gem "redis", "~> 5.0"
-end
-
 appraise "active_support_8-0_redis_cache_store" do
   gem "activesupport", "~> 8.0.0"
   gem "redis", "~> 5.0"
 end
 
-appraise "active_support_8-0_redis_cache_store_pooled" do
-  gem "activesupport", "~> 8.0.0"
-  gem "connection_pool", "~> 2.2"
-  gem "redis", "~> 5.0"
-end
-
 appraise "active_support_7-2_redis_cache_store" do
   gem "activesupport", "~> 7.2.0"
   gem "redis", "~> 5.0"
 end
 
-appraise "active_support_7-2_redis_cache_store_pooled" do
-  gem "activesupport", "~> 7.2.0"
-  gem "connection_pool", "~> 2.2"
-  gem "redis", "~> 5.0"
-end
-
 appraise "active_support_7-1_redis_cache_store" do
   gem "activesupport", "~> 7.1.0"
   gem "redis", "~> 5.0"
 end
 
-appraise "active_support_7-1_redis_cache_store_pooled" do
-  gem "activesupport", "~> 7.1.0"
-  gem "connection_pool", "~> 2.2"
-  gem "redis", "~> 5.0"
-end
-
 appraise "active_support_7-0_redis_cache_store" do
   gem "activesupport", "~> 7.0.0"
   gem "redis", "~> 5.0"
 end
 
-appraise "active_support_7-0_redis_cache_store_pooled" do
-  gem "activesupport", "~> 7.0.0"
-  gem "connection_pool", "~> 2.2"
-  gem "redis", "~> 5.0"
-end
-
 appraise "redis_store" do
   gem "redis-store", "~> 1.5"
 end

gemfiles/active_support_7_0_redis_cache_store_pooled.gemfile

@@ -46,4 +46,7 @@ Gem::Specification.new do |s|
   end
 
   s.add_development_dependency "activesupport"
+  # Fix activesupport Direct version requirement on connection_pool
+  # can be removed once https://github.com/rails/rails/issues/56291 is ixed and released
+  s.add_development_dependency "connection_pool", "~> 2.5"
 end