Skip to content

Use verify-hardcoded-version pre-commit hook #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleFromNVIDIA wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −9
Open

Use verify-hardcoded-version pre-commit hook #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8576165
Use verify-hardcoded-version pre-commit hook
KyleFromNVIDIA Feb 4, 2026
ff3b17a
Shellcheck
KyleFromNVIDIA Feb 4, 2026
4176b33
Fix
KyleFromNVIDIA Feb 4, 2026
51cd714
More
KyleFromNVIDIA Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ repos:
^CHANGELOG[.]md$|
^cpp/cmake/patches/cutlass/build-export[.]patch$
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v1.3.3
rev: v1.4.3
hooks:
- id: verify-copyright
name: verify-copyright-cuvs
Expand Down Expand Up @@ -170,6 +170,7 @@ repos:
exclude: |
(?x)
^pyproject[.]toml$
- id: verify-hardcoded-version
- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.20.0
hooks:
Expand Down
3 changes: 1 addition & 2 deletions ci/release/update-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0
########################
# CUVS Version Updater #
Expand Down Expand Up @@ -168,7 +168,6 @@ done

# Update Java API version
NEXT_FULL_JAVA_TAG="${NEXT_SHORT_TAG}.${PATCH_PEP440}"
sed_runner "s/VERSION=\".*\"/VERSION=\"${NEXT_FULL_JAVA_TAG}\"/g" java/build.sh
for FILE in java/*/pom.xml; do
sed_runner "/<!--CUVS_JAVA#VERSION_UPDATE_MARKER_START-->.*<!--CUVS_JAVA#VERSION_UPDATE_MARKER_END-->/s//<!--CUVS_JAVA#VERSION_UPDATE_MARKER_START--><version>${NEXT_FULL_JAVA_TAG}<\/version><!--CUVS_JAVA#VERSION_UPDATE_MARKER_END-->/g" "${FILE}"
done
Expand Down
8 changes: 4 additions & 4 deletions java/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#!/bin/bash

# SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0

set -e -u -o pipefail

ARGS="$*"
NUMARGS=$#

VERSION="26.04.0" # Note: The version is updated automatically when ci/release/update-version.sh is invoked
VERSION="$(sed -E -e 's/^([0-9]+\.[0-9]+)\.0?([0-9]*)/\1.\2/' ../VERSION)"
GROUP_ID="com.nvidia.cuvs"

# Identify CUDA major version.
Expand Down Expand Up @@ -48,6 +48,6 @@ fi

cd cuvs-java
mvn clean verify "${MAVEN_VERIFY_ARGS[@]}" -P "$BUILD_PROFILE" \
&& mvn install:install-file -Dfile=./target/cuvs-java-$VERSION.jar -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion=$VERSION -Dpackaging=jar \
&& mvn install:install-file -Dfile=./target/cuvs-java-$VERSION-"$BUILD_PROFILE".jar -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion=$VERSION -Dclassifier="$BUILD_PROFILE" -Dpackaging=jar \
&& mvn install:install-file -Dfile="./target/cuvs-java-$VERSION.jar" -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion="$VERSION" -Dpackaging=jar \
&& mvn install:install-file -Dfile="./target/cuvs-java-$VERSION-$BUILD_PROFILE.jar" -DgroupId=$GROUP_ID -DartifactId=cuvs-java -Dversion="$VERSION" -Dclassifier="$BUILD_PROFILE" -Dpackaging=jar \
&& cp pom.xml ./target/
4 changes: 3 additions & 1 deletion java/cuvs-java/src/test/java/com/nvidia/cuvs/spi/CuVSProviderIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
package com.nvidia.cuvs.spi;
Expand Down Expand Up @@ -105,13 +105,15 @@ public void testMaxVersionOverride() {
ProviderInitializationException.class,
() -> checkCuVSVersionMatching("25.12.0", 26, 4, 0));

// rapids-pre-commit-hooks: disable[verify-hardcoded-version]
assertEquals(
"""
Version mismatch: unsupported libcuvs_c (libcuvs_c [26.04.0], cuvs-java version [25.12.0]). \
Please upgrade your software, or install a previous version of libcuvs_c.\
""",
ex.getMessage());
System.setProperty("cuvs.max_version", "26.12.0");
// rapids-pre-commit-hooks: enable[verify-hardcoded-version]
checkCuVSVersionMatching("25.12.0", 26, 12, 0);
} catch (ProviderInitializationException e) {
throw new AssertionError(e);
Expand Down
3 changes: 2 additions & 1 deletion python/cuvs_bench/cuvs_bench/plot/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
#
# SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
# SPDX-License-Identifier: Apache-2.0

# This script is inspired by
# 1: https://github.com/erikbern/ann-benchmarks/blob/main/plot.py
# 2: https://github.com/erikbern/ann-benchmarks/blob/main/ann_benchmarks/plotting/utils.py # noqa: E501
# 3: https://github.com/erikbern/ann-benchmarks/blob/main/ann_benchmarks/plotting/metrics.py # noqa: E501
# rapids-pre-commit-hooks: disable-next-line[verify-hardcoded-version]
# License: https://github.com/rapidsai/cuvs/blob/main/thirdparty/LICENSES/LICENSE.ann-benchmark # noqa: E501

import itertools
Expand Down
1 change: 1 addition & 0 deletions rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ members = [
resolver = "2"

[workspace.package]
# rapids-pre-commit-hooks: disable-next-line[verify-hardcoded-version]
version = "26.4.0"
edition = "2021"
repository = "https://github.com/rapidsai/cuvs"
Expand Down
1 change: 1 addition & 0 deletions rust/cuvs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ authors.workspace = true
license.workspace = true

[dependencies]
# rapids-pre-commit-hooks: disable-next-line[verify-hardcoded-version]
ffi = { package = "cuvs-sys", path = "../cuvs-sys", version = "26.4.0" }
ndarray = "0.15"

Expand Down