Skip to content

Several doc + code examples are not working #649

@kasper-keunen

Description

@kasper-keunen

Have spent about 2 days hitting my head against the sdk and following examples / readme but apart from being able to read nft market data have been unable to get any write transactions through and since i need to access this sdk to be able to handle a nft ticketing market this is highly annoying.

I will give a few examples, for starters this "Example Application": https://docs.rarible.org/reference/example-application. If you follow the instructions; so clone/pull the sdk and then run yarn install --ignore-engines && yarn bootstrap && yarn build-all. You get the following error:

Screenshot 2024-07-22 at 22 18 19

In this example application: https://example.rarible.org/connect contains a lot of dead links like this one: https://github.com/rarible/sdk/tree/master/packages/connector. Then the deploy/create collection example uses what i think is a dated/old way of creating a collection. The example dapp works, but replicating it is not possible as out of the box createCollction doesn't work.

Screenshot 2024-07-22 at 22 47 07

Then this instruction in the readme on how to create a collection: https://docs.rarible.org/reference/create-collection seems to require CreateCollectionRequestSimplified but this seems to be depreciated? Its hard to tell - what is certain that the example as shown doesn't work.

Screenshot 2024-07-22 at 22 22 56

Then in the sdk documetation on github: https://github.com/rarible/sdk this example on creating an collection is given:

const { address, tx } = await sdk.nft.createCollection({
    blockchain: Blockchain.ETHEREUM,
    type: "ERC721",
    name: "name",
    symbol: "RARI",
    baseURI: "https://ipfs.rarible.com",
    contractURI: "https://ipfs.rarible.com",
    isPublic: true,
})

Running this gives the following error:
Screenshot 2024-07-22 at 22 32 51

And if i then try to use the EVMBlockchain type it doesn't work either. Have no clue what is going on.

Over the last days i have run into more problems but these are the most recent blockers.

As a dev myself i fully understand that updating docs is not fun and it is bound to happen that stuff gets outdated - so honestly that by itself is not a problem. That being said i seem unable to get it to work whatever i do - would be great if there would be at least a working example. I am pretty sure that once all set up the SDK should work great but it seems kind of rough getting a working config/setup on the rails.

Finally i was wondering if wagmi/viem support is coming soon? I noticed in a previous github issue that this addition was planned to be added in march (a few months back). Would be great to know where it stands.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions