Skip to content

Commit 1e8edf9

Browse files
fix: subscription cycle RQL filter issue inside Org billing search API (#901)
* fix rql filtering issues in subscription cycle end date key * fix tests
1 parent acc70f6 commit 1e8edf9

File tree

2 files changed

+34
-33
lines changed

2 files changed

+34
-33
lines changed

internal/store/postgres/org_billing_repository.go

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,29 @@ const (
2525
)
2626

2727
const (
28-
COLUMN_ID = "id"
29-
COLUMN_TITLE = "title"
30-
COLUMN_NAME = "name"
31-
COLUMN_STATE = "state"
32-
COLUMN_CREATED_AT = "created_at"
33-
COLUMN_POC = "poc"
34-
COLUMN_AVATAR = "avatar"
35-
COLUMN_COUNTRY = "country"
36-
COLUMN_INTERVAL = "interval"
37-
COLUMN_TRIAL_ENDS_AT = "trial_ends_at"
38-
COLUMN_CURRENT_PERIOD_END_AT = "current_period_end_at"
39-
COLUMN_CUSTOMER_ID = "customer_id"
40-
COLUMN_PLAN_ID = "plan_id"
41-
COLUMN_ORG_ID = "org_id"
42-
COLUMN_CREATED_BY = "created_by"
43-
COLUMN_PLAN_NAME = "plan_name"
44-
COLUMN_SUBSCRIPTION_STATE = "subscription_state"
45-
COLUMN_UPDATED_AT = "updated_at"
46-
COLUMN_ROW_NUM = "row_num"
47-
COLUMN_PLAN_INTERVAL = "plan_interval"
48-
COLUMN_COUNT = "count"
49-
COLUMN_VALUES = "values"
28+
COLUMN_ID = "id"
29+
COLUMN_TITLE = "title"
30+
COLUMN_NAME = "name"
31+
COLUMN_STATE = "state"
32+
COLUMN_CREATED_AT = "created_at"
33+
COLUMN_POC = "poc"
34+
COLUMN_AVATAR = "avatar"
35+
COLUMN_COUNTRY = "country"
36+
COLUMN_INTERVAL = "interval"
37+
COLUMN_TRIAL_ENDS_AT = "trial_ends_at"
38+
COLUMN_CURRENT_PERIOD_END_AT = "current_period_end_at"
39+
COLUMN_SUBSCRIPTION_CYCLE_END_AT = "subscription_cycle_end_at"
40+
COLUMN_CUSTOMER_ID = "customer_id"
41+
COLUMN_PLAN_ID = "plan_id"
42+
COLUMN_ORG_ID = "org_id"
43+
COLUMN_CREATED_BY = "created_by"
44+
COLUMN_PLAN_NAME = "plan_name"
45+
COLUMN_SUBSCRIPTION_STATE = "subscription_state"
46+
COLUMN_UPDATED_AT = "updated_at"
47+
COLUMN_ROW_NUM = "row_num"
48+
COLUMN_PLAN_INTERVAL = "plan_interval"
49+
COLUMN_COUNT = "count"
50+
COLUMN_VALUES = "values"
5051
)
5152

5253
type OrgBillingRepository struct {
@@ -63,7 +64,7 @@ type OrgBilling struct {
6364
OrgCreatedAt sql.NullTime `db:"created_at"`
6465
OrgCreatedBy sql.NullString `db:"created_by"`
6566
OrgUpdatedAt sql.NullTime `db:"updated_at"`
66-
SubscriptionCycleEndAt sql.NullTime `db:"current_period_end_at"`
67+
SubscriptionCycleEndAt sql.NullTime `db:"subscription_cycle_end_at"`
6768
SubscriptionState sql.NullString `db:"subscription_state"`
6869
PlanInterval sql.NullString `db:"plan_interval"`
6970
Country sql.NullString `db:"country"`
@@ -197,7 +198,7 @@ func prepareDataQuery(rql *rql.Query) (string, []interface{}, error) {
197198
goqu.I(COLUMN_PLAN_ID),
198199
goqu.I(COLUMN_PLAN_NAME),
199200
goqu.I(COLUMN_SUBSCRIPTION_STATE),
200-
goqu.I(COLUMN_CURRENT_PERIOD_END_AT),
201+
goqu.I(COLUMN_SUBSCRIPTION_CYCLE_END_AT),
201202
goqu.I(COLUMN_PLAN_INTERVAL),
202203
}
203204

@@ -289,7 +290,7 @@ func getSubQuery() *goqu.SelectDataset {
289290
goqu.I(TABLE_BILLING_PLANS + "." + COLUMN_INTERVAL).As(COLUMN_PLAN_INTERVAL),
290291
goqu.I(TABLE_BILLING_SUBSCRIPTIONS + "." + COLUMN_STATE).As(COLUMN_SUBSCRIPTION_STATE),
291292
goqu.I(TABLE_BILLING_SUBSCRIPTIONS + "." + COLUMN_TRIAL_ENDS_AT),
292-
goqu.I(TABLE_BILLING_SUBSCRIPTIONS + "." + COLUMN_CURRENT_PERIOD_END_AT),
293+
goqu.I(TABLE_BILLING_SUBSCRIPTIONS + "." + COLUMN_CURRENT_PERIOD_END_AT).As(COLUMN_SUBSCRIPTION_CYCLE_END_AT),
293294
goqu.Literal("ROW_NUMBER() OVER (PARTITION BY ? ORDER BY ? DESC)", goqu.I(TABLE_ORGANIZATIONS+"."+COLUMN_ID),
294295
goqu.I(TABLE_BILLING_SUBSCRIPTIONS+"."+COLUMN_CREATED_AT)).As(COLUMN_ROW_NUM),
295296
}
@@ -323,7 +324,7 @@ func addRQLFiltersInQuery(query *goqu.SelectDataset, rqlInput *rql.Query) (*goqu
323324
COLUMN_CREATED_AT,
324325
COLUMN_PLAN_NAME,
325326
COLUMN_SUBSCRIPTION_STATE,
326-
COLUMN_CURRENT_PERIOD_END_AT,
327+
COLUMN_SUBSCRIPTION_CYCLE_END_AT,
327328
COLUMN_PLAN_INTERVAL,
328329
}
329330

0 commit comments

Comments
 (0)