Skip to content

Commit 27f1a78

Browse files
authored
fix: add popupRender to SubMenuType (#849)
* fix: add popupRender to SubMenuType * chore: remove SubMenuProps popupRender * chore: remove unused types from SubMenu * fix: keep useResizeObserver in resize-observer mock
1 parent a3ae269 commit 27f1a78

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/SubMenu/index.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import Overflow from '@rc-component/overflow';
44
import warning from '@rc-component/util/lib/warning';
55
import SubMenuList from './SubMenuList';
66
import { parseChildren } from '../utils/commonUtil';
7-
import type { MenuInfo, SubMenuType, PopupRender } from '../interface';
7+
import type { MenuInfo, SubMenuType } from '../interface';
88
import MenuContextProvider, { MenuContext } from '../context/MenuContext';
99
import useMemoCallback from '../hooks/useMemoCallback';
1010
import PopupTrigger from './PopupTrigger';
@@ -38,7 +38,6 @@ export interface SubMenuProps extends Omit<SubMenuType, 'key' | 'children' | 'la
3838

3939
/** @private Do not use. Private warning empty usage */
4040
warnKey?: boolean;
41-
popupRender?: PopupRender;
4241
// >>>>>>>>>>>>>>>>>>>>> Next Round <<<<<<<<<<<<<<<<<<<<<<<
4342
// onDestroy?: DestroyEventHandler;
4443
}

src/interface.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ export interface SubMenuType extends ItemSharedProps {
3333
popupClassName?: string;
3434
popupOffset?: number[];
3535
popupStyle?: React.CSSProperties;
36+
popupRender?: PopupRender;
3637

3738
// >>>>> Events
3839
onClick?: MenuClickEventHandler;

tests/Responsive.spec.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jest.mock('@rc-component/resize-observer', () => {
1515

1616
let guid = 0;
1717

18-
return R.forwardRef((props, ref) => {
18+
const MockResizeObserver = R.forwardRef((props, ref) => {
1919
const [id] = R.useState(() => {
2020
guid += 1;
2121
return guid;
@@ -26,6 +26,9 @@ jest.mock('@rc-component/resize-observer', () => {
2626

2727
return R.createElement(RO, { ref, ...props });
2828
});
29+
30+
MockResizeObserver.useResizeObserver = RO.useResizeObserver || (() => {});
31+
return MockResizeObserver;
2932
});
3033

3134
describe('Menu.Responsive', () => {

0 commit comments

Comments
 (0)