You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// Copyright (c) {{DateTime.Now.Year}} .NET Foundation and Contributors. All rights reserved.
As I understand, it will violate deterministic build guaranty, when two build cross year boundary.
I think it should be replaced with reference to constant string, so it remain fixed for same package version, and not depend of dependent project build time.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I noticed that there are multiple placed where current year is included into generated source:
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 21 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 83 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 113 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 169 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 223 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 280 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 334 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 383 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 449 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 477 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 505 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/AttributeDefinitions.cs
Line 529 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/RoutedControlHost/RoutedControlHostGenerator.Execute.cs
Line 91 in c33ee56
ReactiveUI.SourceGenerators/src/ReactiveUI.SourceGenerators.Roslyn/ViewModelControlHost/ViewModelControlHostGenerator.Execute.cs
Line 84 in c33ee56
As I understand, it will violate deterministic build guaranty, when two build cross year boundary.
I think it should be replaced with reference to constant string, so it remain fixed for same package version, and not depend of dependent project build time.
Beta Was this translation helpful? Give feedback.
All reactions