[Bug]: SplatRegistrations.RegisterConstant is looking for constructor with DependencyInjectionConstructorAttribute

[CyLuGh]

Describe the bug 🐞

Hello,

When upgrading from v1 to v2, I encounter an issue: even though I instantiate an object and register it as a constant dependency, the generator still tries to find an injection constructor. This fails because the class has multiple constructors, none having the proper attribute (which I can't add, this is another library I'm using).

Step to reproduce

var tracker = new Tracker();
SplatRegistrations.RegisterConstant(tracker);
SplatRegistrations.SetupIOC();

will give this error:

Jot.Tracker has more than one constructor and one hasn't been marked with DependencyInjectionConstructorAttribute

Expected behavior

There shouldn't be any compilation error.

[glennawatson]

You able to give a rough example of what the other library looks like in terms of constructors?

[CyLuGh]

For sure, it's Jot from here: https://github.com/anakic/Jot

The Tracker class is here: https://github.com/anakic/Jot/blob/master/Jot/Tracker.cs and I can see two constructors:

/// <summary>
/// Creates a StateTracker that uses json files in a per-user folder to store the data.
/// </summary>
public Tracker()
    : this(new JsonFileStore())
{
}

/// <summary>
/// Creates a new instance of the state tracker with the specified storage. 
/// </summary>
/// <param name="store">The factory that will create an IStore for each tracked object's data.</param>
public Tracker(
    IStore store)
{
    Store = store;
}

What I don't understand is why the SourceGenerator is looking for a constructor when the instance is provided through the RegisterConstant.

GitHub

GitHub - anakic/Jot: Jot is a library for persisting and applying .NET application state.

Jot is a library for persisting and applying .NET application state. - anakic/Jot

GitHub

Jot/Jot/Tracker.cs at master · anakic/Jot

Jot is a library for persisting and applying .NET application state. - anakic/Jot