feat: add backward compatibility for models.get("owner/name") format#72
Closed
feat: add backward compatibility for models.get("owner/name") format#72
Conversation
This adds support for the legacy models.get("owner/name") format while maintaining
compatibility with the new models.get(model_owner="owner", model_name="name") format.
The implementation directly modifies the generated get() method to:
- Accept an optional positional argument for "owner/name" strings
- Parse and validate the format with clear error messages
- Support both sync and async versions
- Maintain all existing functionality and parameters
This approach is 50% less code than a patching system and integrates cleanly
with the existing codebase structure.
6f10116 to
2804bd6
Compare
8b43277 to
f85db05
Compare
dgellow
reviewed
Oct 9, 2025
dgellow
approved these changes
Oct 9, 2025
Collaborator
dgellow
left a comment
There was a problem hiding this comment.
Reviewing my own implementation :)
ea6fa72 to
26638e7
Compare
Member
Author
|
Per our discussion IRL yesterday, let's scrap this. If it turns out to be a big issue for users we can consider supporting it. This change between v1 and v2 is covered in the migration guide: #76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds backward compatibility for the legacy
models.get("owner/name")format while maintaining full compatibility with the newmodels.get(model_owner="owner", model_name="name")format.Changes
get()method in both sync and asyncModelsResourceclasses to accept an optional positional argument for legacy formatImplementation Approach
The implementation directly modifies the generated
get()method to:model_or_owneras an optional positional parameterThis approach is 50% less code than a patching system and integrates cleanly with the existing codebase structure.
Testing locally