Fix branch filter showing no results due to limited fetch (#147)

## Summary
Fixes a bug where branch filter in the TUI would show "no matching jobs"
even when matching jobs existed in the database.

## Root Cause
When branch filter was active, `fetchJobs` only fetched a limited number
of recent jobs (e.g., 50). Since branch filtering is done client-side,
if none of those 50 jobs matched the filtered branch, the TUI showed 0
results.

## Fix
- Fetch all jobs (`limit=0`) when branch filter is active, matching
existing behavior for repo filter and hideAddressed modes
- Disable pagination when branch filter is active since all data is
already loaded

## Test plan
- [x] Added `TestTUINavigateDownNoLoadMoreWhenBranchFiltered` test
- [x] All existing tests pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: wesm

cmd/roborev/tui.go

@@ -489,7 +489,7 @@ func (m tuiModel) fetchJobs() tea.Cmd {
 
 	return func() tea.Msg {
 		// Determine limit:
-		// - No limit (limit=0) when filtering to show full repo/addressed history
+		// - No limit (limit=0) when filtering to show full repo/branch/addressed history
 		// - If we've paginated beyond visible area, maintain current view size
 		// - Otherwise fetch enough to fill visible area
 		var url string
@@ -499,6 +499,9 @@ func (m tuiModel) fetchJobs() tea.Cmd {
 		} else if len(m.activeRepoFilter) > 1 {
 			// Multiple repos (shared display name) - fetch all, filter client-side
 			url = fmt.Sprintf("%s/api/jobs?limit=0", m.serverAddr)
+		} else if m.activeBranchFilter != "" {
+			// Fetch all jobs when filtering by branch - client-side filtering needs full dataset
+			url = fmt.Sprintf("%s/api/jobs?limit=0", m.serverAddr)
 		} else if m.hideAddressed {
 			// Fetch all jobs when hiding addressed - client-side filtering needs full dataset
 			url = fmt.Sprintf("%s/api/jobs?limit=0", m.serverAddr)
@@ -533,7 +536,7 @@ func (m tuiModel) fetchJobs() tea.Cmd {
 func (m tuiModel) fetchMoreJobs() tea.Cmd {
 	return func() tea.Msg {
 		// Only fetch more when not filtering (filtered view loads all)
-		if len(m.activeRepoFilter) > 0 {
+		if len(m.activeRepoFilter) > 0 || m.activeBranchFilter != "" {
 			return nil
 		}
 		offset := len(m.jobs)
@@ -1759,8 +1762,18 @@ func (m tuiModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 					}
 					m.currentView = tuiViewQueue
 					m.branchFilterSearch = ""
-					// Selection stays valid - client-side filtering
-					return m, nil
+					// Branch filter changes fetch behavior (limited vs unlimited),
+					// so we need to refetch
+					m.jobs = nil
+					m.hasMore = false
+					m.selectedIdx = -1
+					m.selectedJobID = 0
+					if m.loadingJobs || m.loadingMore {
+						m.pendingRefetch = true
+						return m, nil
+					}
+					m.loadingJobs = true
+					return m, m.fetchJobs()
 				}
 				return m, nil
 			case "backspace":
@@ -2404,8 +2417,8 @@ func (m tuiModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			if m.currentView == tuiViewQueue && len(m.filterStack) > 0 {
 				// Pop the most recent filter from the stack
 				popped := m.popFilter()
-				if popped == "repo" {
-					// Repo filter is server-side, need to refetch
+				if popped == "repo" || popped == "branch" {
+					// Repo/branch filter changes fetch behavior, need to refetch
 					m.jobs = nil
 					m.hasMore = false
 					m.selectedIdx = -1
@@ -2417,7 +2430,6 @@ func (m tuiModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 					m.loadingJobs = true
 					return m, m.fetchJobs()
 				}
-				// Branch filter is client-side, no refetch needed
 				return m, nil
 			} else if m.currentView == tuiViewQueue && m.hideAddressed {
 				// Clear hide-addressed filter (no project/branch filter active)

cmd/roborev/tui_test.go

@@ -7386,6 +7386,89 @@ func TestTUIRemoveFilterFromStack(t *testing.T) {
 	}
 }
 
+func TestTUINavigateDownNoLoadMoreWhenBranchFiltered(t *testing.T) {
+	// Test that pagination is disabled when branch filter is active
+	// (since branch filtering fetches all jobs upfront)
+	m := newTuiModel("http://localhost")
+
+	// Set up at last job with branch filter active
+	m.jobs = []storage.ReviewJob{{ID: 1, Branch: "feature"}}
+	m.selectedIdx = 0
+	m.selectedJobID = 1
+	m.hasMore = true
+	m.loadingMore = false
+	m.activeBranchFilter = "feature" // Branch filter active
+	m.currentView = tuiViewQueue
+
+	// Press down at bottom - should NOT trigger load more (filtered view loads all)
+	updated, cmd := m.Update(tea.KeyMsg{Type: tea.KeyDown})
+	m2 := updated.(tuiModel)
+
+	if m2.loadingMore {
+		t.Error("loadingMore should not be set when branch filter is active")
+	}
+	if cmd != nil {
+		t.Error("Should not return command when branch filter is active")
+	}
+}
+
+func TestTUIBranchFilterTriggersRefetch(t *testing.T) {
+	// Test that applying a branch filter triggers a refetch
+	// (needed because branch filter changes fetch from limited to unlimited)
+	m := newTuiModel("http://localhost")
+
+	m.currentView = tuiViewBranchFilter
+	m.filterBranches = []branchFilterItem{
+		{name: "main", count: 5},
+		{name: "feature", count: 3},
+	}
+	m.branchFilterSelectedIdx = 1 // Select "feature"
+	m.jobs = []storage.ReviewJob{
+		{ID: 1, Branch: "main"},
+		{ID: 2, Branch: "feature"},
+	}
+	m.loadingJobs = false
+
+	// Press Enter to select
+	updated, cmd := m.Update(tea.KeyMsg{Type: tea.KeyEnter})
+	m2 := updated.(tuiModel)
+
+	if !m2.loadingJobs {
+		t.Error("loadingJobs should be true after applying branch filter")
+	}
+	if m2.jobs != nil {
+		t.Error("jobs should be cleared when applying branch filter")
+	}
+	if cmd == nil {
+		t.Error("Should return fetchJobs command when applying branch filter")
+	}
+}
+
+func TestTUIBranchFilterClearTriggersRefetch(t *testing.T) {
+	// Test that clearing a branch filter triggers a refetch
+	m := newTuiModel("http://localhost")
+
+	m.currentView = tuiViewQueue
+	m.activeBranchFilter = "feature"
+	m.filterStack = []string{"branch"}
+	m.jobs = []storage.ReviewJob{{ID: 1, Branch: "feature"}}
+	m.loadingJobs = false
+
+	// Press Escape to clear filter
+	updated, cmd := m.Update(tea.KeyMsg{Type: tea.KeyEscape})
+	m2 := updated.(tuiModel)
+
+	if m2.activeBranchFilter != "" {
+		t.Errorf("Expected activeBranchFilter to be cleared, got '%s'", m2.activeBranchFilter)
+	}
+	if !m2.loadingJobs {
+		t.Error("loadingJobs should be true after clearing branch filter")
+	}
+	if cmd == nil {
+		t.Error("Should return fetchJobs command when clearing branch filter")
+	}
+}
+
 // Backfill gating tests
 
 func TestTUIBranchBackfillDoneSetWhenNoNullsRemain(t *testing.T) {