-
Notifications
You must be signed in to change notification settings - Fork 500
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
follow up of #2988
AllocatorMemoryStrategy and related code is "dead code" that was part of the old executor (StaticSingleThreadedExecutor in the last) implementation before the double buffering changes introduced shortly before Jazzy.
We need to deprecate AllocatorMemoryStrategy and remove related test files and scenarios all together. Deprecation period requires one distro release, that said deprecation warning stays in Lyrical Luth, and on turtle-M we can remove AllocatorMemoryStrategy.
with quick code scan, i see the following needs to be done.
- deprecate
AllocatorMemoryStrategy<Alloc>andMemoryStrategy(base class) including all methods. test_allocator_memory_strategy.cpp,test_memory_strategy.cppcan be removed.- Executor options should be adjusted with this deprecation.
- External packages using custom allocators? (
realtime_support,demos)
could be more.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed