Skip to content

Add expression_types(), pattern_types(), binding_types() to DefWithBody #21584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
regexident wants to merge 1 commit into
base: master
Choose a base branch
from
+44 −0
Open

Add expression_types(), pattern_types(), binding_types() to DefWithBody #21584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions crates/hir/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,6 +2244,50 @@ impl DefWithBody {
acc.push(diag.into())
}
}

/// Returns an iterator over the inferred types of all expressions in this body.
///
/// Returns `None` for builtin derive impl methods which don't have inference data.
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like calling out builtin derive impls like that. Instead we should just return an empty iterator for them (they behave as if they have no body).

pub fn expression_types<'db>(
self,
db: &'db dyn HirDatabase,
) -> Option<impl Iterator<Item = Type<'db>>> {
let def_id = self.id()?;
let infer = InferenceResult::for_body(db, def_id);
let resolver = def_id.resolver(db);

Some(
infer.expression_types().map(move |(_, ty)| Type::new_with_resolver(db, &resolver, ty)),
)
}

/// Returns an iterator over the inferred types of all patterns in this body.
///
/// Returns `None` for builtin derive impl methods which don't have inference data.
pub fn pattern_types<'db>(
self,
db: &'db dyn HirDatabase,
) -> Option<impl Iterator<Item = Type<'db>>> {
let def_id = self.id()?;
let infer = InferenceResult::for_body(db, def_id);
let resolver = def_id.resolver(db);

Some(infer.pattern_types().map(move |(_, ty)| Type::new_with_resolver(db, &resolver, ty)))
}

/// Returns an iterator over the inferred types of all bindings in this body.
///
/// Returns `None` for builtin derive impl methods which don't have inference data.
pub fn binding_types<'db>(
self,
db: &'db dyn HirDatabase,
) -> Option<impl Iterator<Item = Type<'db>>> {
let def_id = self.id()?;
let infer = InferenceResult::for_body(db, def_id);
let resolver = def_id.resolver(db);

Some(infer.binding_types().map(move |(_, ty)| Type::new_with_resolver(db, &resolver, ty)))
}
}

fn expr_store_diagnostics<'db>(
Expand Down