macOS: Documentation claims winit won't register application delegate, but it does (and panics if replaced)

[SuchAFuriousDeath]

Description

The macOS platform documentation (for v0.30.12) states:

Instead, Winit guarantees that it will not register an application delegate, so the solution is to register your own application delegate [...]

https://docs.rs/winit/0.30.12/winit/platform/macos/

However, this is not accurate in v0.30.12. Winit does register its own ApplicationDelegate (WinitApplicationDelegate), and will panic if you replace it with your own.

https://github.com/rust-windowing/winit/blob/v0.30.12/src/platform_impl/macos/event_loop.rs#L240
https://github.com/rust-windowing/winit/blob/v0.30.12/src/platform_impl/macos/app_state.rs#L174-L183

macOS version

Doesn't matter to this issue, it's macOS-specific, but in the documentation.

Winit version

v0.30.12

[kchibisov]

You're reading docs for master, not for your version. master or betas don't do so, so use latest beta.

[SuchAFuriousDeath]

That is not true, I linked to docs for v0.30.12, not for master

[SuchAFuriousDeath]

I am aware that v0.31 beta does not set a delegate and no longer panics, but the documentation for the current stable version states that this applies to v0.30.12 as well. but it does not.

[kchibisov]

Hm, true, it got cherry picked into bugfix branch.

cc @madsmtm

[SuchAFuriousDeath]

v0.30.9 is fine, but v0.30.10 is already wrong.

[kchibisov]

The code is there, it's just looks like doesn't really work.

[SuchAFuriousDeath]

Isn't only the documentation cherry-picked? And the actual code changes were not cherrypicked?

[kchibisov]

They seem to cherry pick, but could be that something doesn't really work with the things that they are on 0.30.12. The commit is 53321dc.

[SuchAFuriousDeath]

That commit is related to NsApplication, but the issue at hand is about NsApplicationDelegate. Or I am misunderstanding something.

[SuchAFuriousDeath]

I think this cherrypick was incorrect: 57baf72

It seems to pick up the documentation change for macOS that says winit will not set a delegate, but not the actual corresponding code change.
Given that the commit seems iOS related, the documentation change was probably picked up by accident.