Skip to content

Commit 198743f

Browse files
authored
Extensions: fix install button type and place of alert in menu (#5508)
* Fix install button * Fix list group adornment
1 parent 2797a6a commit 198743f

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/components/Sidebar/menu/ItemGroup.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,9 @@ export const ItemGroup: React.FC<Props> = ({ menuItem }) => {
4141
<Text size={3} fontWeight="medium">
4242
{menuItem.label}
4343
</Text>
44+
{menuItem.endAdornment && <Box>{menuItem.endAdornment}</Box>}
4445
</Box>
4546
</Link>
46-
{menuItem.endAdornment && (
47-
<Box position="absolute" right={9} top={2} zIndex={"3"}>
48-
{menuItem.endAdornment}
49-
</Box>
50-
)}
5147
</List.ItemGroup.Trigger>
5248
<List.ItemGroup.Content>
5349
<Box

src/extensions/components/ExtenionItem/components/AppInstallButton.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const AppInstallButton = ({ manifestUrl }: { manifestUrl: string }) => {
1717
if (!hasManagedAppsPermission) {
1818
return (
1919
<ButtonWithTooltip
20-
variant="primary"
20+
variant="secondary"
2121
disabled
2222
tooltip={intl.formatMessage(buttonMessages.noPermission)}
2323
>
@@ -29,7 +29,7 @@ export const AppInstallButton = ({ manifestUrl }: { manifestUrl: string }) => {
2929
if (IS_CLOUD_INSTANCE) {
3030
return (
3131
<Link href={AppUrls.resolveAppInstallUrl(manifestUrl)}>
32-
<Button variant="primary" data-test-id="app-install-button">
32+
<Button variant="secondary" data-test-id="app-install-button">
3333
<FormattedMessage {...buttonMessages.install} />
3434
</Button>
3535
</Link>
@@ -39,6 +39,7 @@ export const AppInstallButton = ({ manifestUrl }: { manifestUrl: string }) => {
3939
return (
4040
<span tabIndex={0}>
4141
<ButtonWithTooltip
42+
variant="secondary"
4243
tooltip={intl.formatMessage(messages.installationCloudOnly)}
4344
data-test-id="app-install-button"
4445
disabled

0 commit comments

Comments
 (0)