Use the same return format in all implementations of 'getPersonFromDB'

Signed-off-by: Maximilian Löffler <s8maloef@stud.uni-saarland.de>

Author: maxloeffler

codeface_utils/cluster/idManager.py

@@ -296,11 +296,10 @@ def _query_user_id(self, name, email):
             raise Exception("Constructed author list is in invalid format. Duplicate entries found")
 
     def getPersonFromDB(self, person_id):
-        """Get a PersonInfo instance from the database by ID."""
-        if person_id not in self.persons:
-            rows = self.df[self.df['ID'] == person_id]
-            if len(rows) == 1:
-                name = rows['name'].values[0]
-                email = rows['email'].values[0]
-                self.persons[person_id] = PersonInfo(person_id, name, email)
-        return self.persons.get(person_id, None)
+        rows = self.df[self.df['ID'] == person_id]
+        if len(rows) == 1:
+            return {
+                'ID': person_id,
+                'name': rows['name'].values[0],
+                'email1': rows['email'].values[0]
+            }

issue_processing/issue_processing.py

@@ -725,11 +725,8 @@ def get_user_from_id(idx, buffer_db=user_buffer):
 
         # get person information from ID service
         log.info("Passing user id '{}' to ID service.".format(idx))
-        person = idservice.getPersonFromDB(idx)
-        user = dict()
-        user["email"] = person.getEmail()  # column "email1"
-        user["name"] = person.getName()  # column "name"
-        user["id"] = person.getID()  # column "id"
+        user = idservice.getPersonFromDB(idx)
+        user["email"] = user.pop("email1")
 
         # add user information to buffer
         buffer_db[idx] = user

issue_processing/jira_issue_processing.py

@@ -639,11 +639,8 @@ def get_user_from_id(idx, buffer_db=user_buffer):
 
         # get person information from ID service
         log.info("Passing user id '{}' to ID service.".format(idx))
-        person = idservice.getPersonFromDB(idx)
-        user = dict()
-        user["email"] = person["email1"]  # column "email1"
-        user["name"] = person["name"]  # column "name"
-        user["id"] = person["id"]  # column "id"
+        user = idservice.getPersonFromDB(idx)
+        user["email"] = user.pop("email1")
 
         # add user information to buffer
         buffer_db[idx] = user