Skip to content

http2 sessions should be closed? #28

@tmm1

Description

@tmm1

From the nodejs docs for http2server.close():

Stops the server from establishing new sessions. This does not prevent new request streams from being created due to the persistent nature of HTTP/2 sessions. To gracefully shut down the server, call http2session.close() on all active sessions.

I see where server.close() happens:

debug('Close http server');
return new Promise((resolve, reject) => {
server.close((err) => {

But it wasn't clear to me that the active and idle sessions are being closed correctly?

Is this expected to be covered by the Connection: close header for the http2 case as well?

if (!serverResponse.headersSent) {
serverResponse.setHeader('connection', 'close');

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions