-
-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
From the nodejs docs for http2server.close():
Stops the server from establishing new sessions. This does not prevent new request streams from being created due to the persistent nature of HTTP/2 sessions. To gracefully shut down the server, call http2session.close() on all active sessions.
I see where server.close() happens:
http-graceful-shutdown/lib/index.js
Lines 206 to 209 in dd23f5a
| debug('Close http server'); | |
| return new Promise((resolve, reject) => { | |
| server.close((err) => { |
But it wasn't clear to me that the active and idle sessions are being closed correctly?
Is this expected to be covered by the Connection: close header for the http2 case as well?
http-graceful-shutdown/lib/index.js
Lines 120 to 121 in dd23f5a
| if (!serverResponse.headersSent) { | |
| serverResponse.setHeader('connection', 'close'); |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels