[CLNP-7019] fix: URL link text color blending with background in Thread#1393
Closed
OnestarLee wants to merge 3 commits intomainfrom
Closed
[CLNP-7019] fix: URL link text color blending with background in Thread#1393OnestarLee wants to merge 3 commits intomainfrom
OnestarLee wants to merge 3 commits intomainfrom
Conversation
TextFragment was using MessageContext to get isByMe value, but parent components (OGMessageItemBody, TextMessageItemBody, etc.) were not wrapped in MessageProvider, causing isByMe to always be false. This resulted in URL links in outgoing messages having ONBACKGROUND_1 color (dark text) instead of ONCONTENT_1 (white text), making them blend into the purple background and become unreadable. Fix: Add optional isByMe prop to TextFragment that takes precedence over context value, and pass it from all parent components. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…read' into fix/url-message-text-color-in-thread
OnestarLee
force-pushed
the
fix/url-message-text-color-in-thread
branch
from
7336557 to
ee2d020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isByMeprop toTextFragmentcomponent to properly pass the value from parent componentsTicket
https://sendbird.atlassian.net/browse/CLNP-7019
Changelogs
Checklist