Skip to content
This repository was archived by the owner on Nov 4, 2020. It is now read-only.

Commit cc2f68b

Browse files
committed
Release 13.1.3
1 parent 76ed8ce commit cc2f68b

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

History.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
13.1.3 / 2017-10-28
2+
===================
3+
4+
* Fix weird bug in `.containDeep` when given object is string (see \#157)
5+
16
13.1.2 / 2017-10-10
27
===================
38

package.json

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "should",
33
"description": "test framework agnostic BDD-style assertions",
4-
"version": "13.1.2",
4+
"version": "13.1.3",
55
"author": "TJ Holowaychuk <tj@vision-media.ca>, Denis Bardadym <bardadymchik@gmail.com>",
66
"typings": "./should.d.ts",
77
"repository": {
@@ -16,7 +16,8 @@
1616
"prepare": "npm run build && npm run build:umd && npm run build:cjs:as-function",
1717
"pretest": "npm run build",
1818
"build:cjs:as-function": "rollup --input ./lib/should.js --output.format=cjs --output.file ./as-function.js",
19-
"test": "mocha -R mocha-better-spec-reporter --require ./cjs/should --color --check-leaks ./test/*.test.js ./test/**/*.test.js",
19+
"test":
20+
"mocha -R mocha-better-spec-reporter --require ./cjs/should --color --check-leaks ./test/*.test.js ./test/**/*.test.js",
2021
"zuul": "zuul -- ./test/**/*.test.js ./test/*.test.js",
2122
"build:umd": "rollup -c rollup.config.js --input ./lib/umd.js --output.format=iife --output.file ./should.js"
2223
},
@@ -33,12 +34,7 @@
3334
"typescript": "^2.5.3",
3435
"zuul": "latest"
3536
},
36-
"keywords": [
37-
"test",
38-
"bdd",
39-
"assert",
40-
"should"
41-
],
37+
"keywords": ["test", "bdd", "assert", "should"],
4238
"main": "./cjs/should.js",
4339
"module": "./es6/should.js",
4440
"license": "MIT",
@@ -49,13 +45,5 @@
4945
"should-type-adaptors": "^1.0.1",
5046
"should-util": "^1.0.0"
5147
},
52-
"files": [
53-
"cjs/*",
54-
"es6/*",
55-
"as-function.js",
56-
"should.js",
57-
"LICENSE",
58-
"*.md",
59-
"should.d.ts"
60-
]
48+
"files": ["cjs/*", "es6/*", "as-function.js", "should.js", "LICENSE", "*.md", "should.d.ts"]
6149
}

should.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*!
22
* should - test framework agnostic BDD-style assertions
3-
* @version v13.1.2
3+
* @version v13.1.3
44
* @author TJ Holowaychuk <tj@vision-media.ca>, Denis Bardadym <bardadymchik@gmail.com>
55
* @link https://github.com/shouldjs/should.js
66
* @license MIT
@@ -3428,7 +3428,7 @@ var containAssertions = function(should, Assertion) {
34283428
this.params = { operator: "to contain " + i(other) };
34293429

34303430
var obj = this.obj;
3431-
if (typeof obj == "string") {
3431+
if (typeof obj === "string" && typeof other === "string") {
34323432
// expect other to be string
34333433
this.is.equal(String(other));
34343434
} else if (isIterable(obj) && isIterable(other)) {

0 commit comments

Comments
 (0)