chore: Improve Documentation#690
Conversation
|
Claude finished @AgeManning's task —— View job Documentation Review CompleteTasks
Overall AssessmentThis documentation PR improves the structure and usability of the Anchor documentation. The additions of migration guide and validator setup instructions are valuable. The removal of the obsolete CLI check from workflows is appropriate. Issues FoundCritical Issues1. Broken Link in Landing Page (docs/docs/pages/index.mdx:23) The landing page links to <a href="/switch_to_anchor" className="btn btn-secondary">Switch to Anchor</a>This needs to be changed to 2. Inconsistent Link Reference (docs/docs/pages/running_an_operator.mdx:7) References [switching to anchor](/switching_to_anchor)Should be Documentation Accuracy Issues3. Incorrect Flag in CLI Example (docs/docs/pages/running_an_operator.mdx:92) The example uses # Current (incorrect)
anchor node \
--datadir ~/.anchor/hoodi \
# Should be
anchor node \
--data-dir ~/.anchor/hoodi \Actually, looking at the text above (line 98), you mention the flag can be omitted since it uses default values, so this could just be removed from the example entirely. 4. Missing The example shows: anchor keygen --encrypt --output-path /path/to/keys/directoryHowever, based on the keygen code ( anchor keygen --encrypt --data-dir /path/to/keys/directory5. Inconsistent Terminology As you noted, the landing page uses "Switch to Anchor" while the documentation uses "Migrate to Anchor". For consistency:
I suggest keeping "Migrate to Anchor" throughout as it's more technically accurate for the operation being performed. Minor Issues6. Version Number Inconsistency (docs/docs/pages/installation.mdx:38) The example shows version 7. Typo in Landing Page (docs/docs/pages/index.mdx:107) "reguarly" should be "regularly": <p>We reguarly fuzz both the Anchor and the go-ssv client8. Grammar Issue (docs/docs/pages/introduction.mdx:22) Double "is": Anchor specifically is is optimized for efficiencyShould be: Anchor is specifically optimized for efficiency9. Missing Network Option in keysplit Example (docs/docs/pages/cli-keysplit.mdx:58) The manual keysplit example doesn't include the Positive Aspects
Recommendations
SummaryThe documentation improvements are valuable, but there are several critical link errors and CLI flag inaccuracies that need to be fixed before merging. The broken links will result in 404 errors for users, and the incorrect CLI flags will cause confusion and failed commands. Priority fixes needed:
|
|
@claude Isn't |
|
Claude finished @dknopik's task —— View job Investigating
|
|
@claude can you please implement your remaining suggestions? If necessary, open a PR against Age's branch. |
|
Claude finished @dknopik's task —— View job Implementing Documentation Fixes
|
|
I think I bricked it ;( |
I don't think he has perms for new branch PRS. I will look into it |
|
@jking-aus nah I just wanted to try it :) definitely not urgent. I bet I could instruct my local claude to read the comment and perform the edits, which is probably more reasonable than me vibecoding though the github comment section |
|
@claude Can you review the current state of the PR now. Is it up to your standards? |
|
Claude finished @AgeManning's task —— View job Reviewing Current PR State
|
|
There isn't much questions on discord about Anchor yet, but I will think of something to put in the faqs |
| # Specific version example | ||
| https://github.com/sigp/anchor/releases/download/v0.3.1/anchor-v0.3.1-x86_64-unknown-linux-gnu.tar.gz | ||
| tar -xvf anchor-v0.3.1-x86_64-unknown-linux-gnu.tar.gz | ||
| wget https://github.com/sigp/anchor/releases/download/v1.0.0-rc.1/anchor-v1.0.0-rc.1-x86_64-unknown-linux-gnu.tar.gz |
There was a problem hiding this comment.
I am unsure if our version update script can properly replace the -rc.1, it looks like the regex is just replacing the part consisting of digits and dots?
There was a problem hiding this comment.
maybe we should either put 0.0.0 so that it is obvious that this is to be replaced, or put some obvious placeholder like ##VERSION##
There was a problem hiding this comment.
Yeah nice catch. The regex didn't include the rc versions. I've improved the regex so that it does.
That script didn't include this file however. This file had hard-coded examples. Figure might as well update this, so changed the script to include this file.
Of course with scripts like this, if the filename changes or format changes it will break. But I think the main page probably will most likely be static and if this page changes, I think its fine to have an out-of-date example.

This improves the anchor documentation (at least I hope its an improvement).
I've modified some of the example commands, updated the CLI reference guide, added a
migrating to anchorsection as well as aRunning a Validator on SSVsection.I've modified the main landing page, to feature switching to anchor. I am aware that the landing page says
switchingand the docs saymigrating. I liked switching on the landing, happy to change though for consistency.I removed an obsolete CLI check, that I believe is now doing nothing.
This PR probably does need some level of eye-balling to make sure the changes are sound. Especially around the migrating, as I didn't actually test that.
Future Work
I think the FAQ section might need some love. Maybe there have been some questions on discord that might be useful cc @chong-he