ci: fix workflow configuration format and add timeout#713
ci: fix workflow configuration format and add timeout#713mergify[bot] merged 2 commits intosigp:unstablefrom
Conversation
- Use multi-line YAML format for workflow arguments (required format) - Add 15-minute timeout to prevent infinite hangs - Ensures proper parsing of max-turns parameter
|
Claude finished @diegomrsantos's task —— View job Code Review CompleteTasks
Review SummaryThis PR makes two changes to the Claude mentions workflow:
Detailed Feedback✅ Positive ObservationsFormat Fix: The conversion from single-line to multi-line YAML format is correct and follows GitHub Actions best practices. The previous format: claude_args: "--model us.anthropic.claude-sonnet-4-5-20250929-v1:0 --max-turns 50"is now properly structured as: claude_args: |
--max-turns 50
--model us.anthropic.claude-sonnet-4-5-20250929-v1:0This uses the YAML literal block scalar ( Timeout Addition: Adding 📋 Observations & Suggestions
🔒 SecurityNo security concerns identified. The changes don't introduce new security risks. ⚡ PerformanceThe multi-line format may actually improve parsing performance as it's the native YAML way to handle multi-line strings. ✅ TestingRecommendation: While this change looks correct, it should be tested in a real workflow run to ensure:
📝 Code QualityThe YAML syntax is correct and follows GitHub Actions conventions. The change is minimal and focused, which reduces risk. ConclusionThis is a straightforward fix that addresses a real problem (workflow hanging) with an appropriate solution (proper YAML format + timeout). The changes are minimal, focused, and follow best practices. Recommendation: ✅ Approve with the minor suggestions above for consideration. |
Fixes workflow not completing tasks and hanging indefinitely. 1. **Fix Configuration Format**: Updated workflow arguments to use multi-line YAML format (required by the action) 2. **Add Timeout**: Added 15-minute timeout to prevent infinite hangs Co-Authored-By: diego <diego@sigmaprime.io>
Issue Addressed
Fixes workflow not completing tasks and hanging indefinitely.
Proposed Changes
Additional Info
The single-line string format was not being parsed correctly, causing parameters to be ignored. Multi-line format ensures proper parsing and execution.