docs: Add warning for key format issue#714
Conversation
|
Claude finished @dknopik's task —— View job Code Review CompleteTasks
Review SummaryThis PR adds a helpful warning to the migration documentation about a key format compatibility issue between go-ssv and Anchor. The documentation change is clear and actionable. Detailed ReviewDocumentation Quality ✅The warning is well-placed in the migration guide where users would naturally encounter the issue. The message clearly:
Technical Accuracy ✅I verified the underlying code in #[serde(rename = "pubKey")]
pubkey: Option<String>,Anchor expects Suggestions for Improvement1. Add file path reference -If Anchor fails to start with the message `Unable to parse key: unknown field pubkey, expected one of pubKey (...)`, please change "pubkey" to "pubKey" in the encrypted_private_key.json file.
+If Anchor fails to start with the message `Unable to parse key: unknown field pubkey, expected one of pubKey (...)`, please change `"pubkey"` to `"pubKey"` in your `encrypted_private_key.json` file (typically located at `~/.anchor/<network>/encrypted_private_key.json`).2. Consider mentioning the root cause :::warning
If Anchor fails to start with the message `Unable to parse key: unknown field pubkey, expected one of pubKey (...)`, this indicates the key file uses an older format from go-ssv. Please change `"pubkey"` to `"pubKey"` in your `encrypted_private_key.json` file. This compatibility issue will be fixed in a future release.
:::3. Minor formatting improvement Overall AssessmentApprove with minor suggestions. This is a valuable addition that will prevent user confusion during migration. The warning:
The suggestions above are optional enhancements - the PR is good to merge as-is if you prefer to keep it minimal. |
👍 , wdyt? |
Issue Addressed
pubkeyandpubKeyin encrypted_private_key.json #712Proposed Changes
To avoid user confusion and to provide a workaround, give a short explanation in the docs until a fix is released in a stable version.