Regression in `DataColumnsByRange` responses (duplicates included)

[michaelsproul]

Description

This line is wrong:

lighthouse/beacon_node/network/src/network_beacon_processor/rpc_methods.rs

Lines 979 to 980 in 2f7a1f3

	// remove all skip slots i.e. duplicated roots
	Ok(block_roots.into_iter().unique().collect::<Vec<_>>())

Regression was introduced in:

• Add Gloas data column support  #8682

The method previously returned Vec<Hash256> which de-duplicated correctly. But now returns Vec<(Hash256, Slot)> which does not de-duplicate blocks correctly because the slots are unique. This results in duplicate columns being served to peers, and down-scoring by those peers (DuplicatedData errors).

Version

This is a bug in v8.1.0 only.

[jimmygchen]

Fixed in #8843