From c91e03ec453007f81051eaf441a4f12e25300274 Mon Sep 17 00:00:00 2001 From: Tan Chee Keong Date: Wed, 30 Apr 2025 14:58:30 +0800 Subject: [PATCH 1/2] Delete todo --- common/logging/src/sse_logging_components.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/logging/src/sse_logging_components.rs b/common/logging/src/sse_logging_components.rs index a25b5be6c5a..37bfca6a75c 100644 --- a/common/logging/src/sse_logging_components.rs +++ b/common/logging/src/sse_logging_components.rs @@ -1,5 +1,4 @@ -// TODO(tracing) fix the comments below and remove reference of slog::Drain -//! This module provides an implementation of `slog::Drain` that optionally writes to a channel if +//! This module provides an implementation of `tracing` that optionally writes to a channel if //! there are subscribers to a HTTP SSE stream. use serde_json::json; From f9825954444660188a6e7dd8106afeabb9782deb Mon Sep 17 00:00:00 2001 From: chonghe <44791194+chong-he@users.noreply.github.com> Date: Tue, 6 May 2025 10:54:47 +0800 Subject: [PATCH 2/2] Update common/logging/src/sse_logging_components.rs Co-authored-by: Mac L --- common/logging/src/sse_logging_components.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/logging/src/sse_logging_components.rs b/common/logging/src/sse_logging_components.rs index 37bfca6a75c..d526f2b040d 100644 --- a/common/logging/src/sse_logging_components.rs +++ b/common/logging/src/sse_logging_components.rs @@ -1,4 +1,4 @@ -//! This module provides an implementation of `tracing` that optionally writes to a channel if +//! This module provides an implementation of `tracing_subscriber::layer::Layer` that optionally writes to a channel if //! there are subscribers to a HTTP SSE stream. use serde_json::json;