-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathqueuerMaster_test.go
More file actions
393 lines (315 loc) · 14.7 KB
/
queuerMaster_test.go
File metadata and controls
393 lines (315 loc) · 14.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
package queuer
import (
"context"
"testing"
"time"
"github.com/siherrmann/queuer/model"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestMasterTicker(t *testing.T) {
envs := map[string]string{
"QUEUER_DB_HOST": "localhost",
"QUEUER_DB_PORT": dbPort,
"QUEUER_DB_DATABASE": "database",
"QUEUER_DB_USERNAME": "user",
"QUEUER_DB_PASSWORD": "password",
"QUEUER_DB_SCHEMA": "public",
"QUEUER_DB_SSLMODE": "disable",
}
for key, value := range envs {
t.Setenv(key, value)
}
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
t.Run("Master ticker fails with nil old master", func(t *testing.T) {
var oldMaster *model.Master
masterSettings := &model.MasterSettings{
MasterPollInterval: 5 * time.Second,
}
err := queuer.masterTicker(ctx, oldMaster, masterSettings)
assert.Error(t, err, "Expected error starting master ticker with nil old master")
})
}
func TestCheckStaleWorkers(t *testing.T) {
envs := map[string]string{
"QUEUER_DB_HOST": "localhost",
"QUEUER_DB_PORT": dbPort,
"QUEUER_DB_DATABASE": "database",
"QUEUER_DB_USERNAME": "user",
"QUEUER_DB_PASSWORD": "password",
"QUEUER_DB_SCHEMA": "public",
"QUEUER_DB_SSLMODE": "disable",
}
for key, value := range envs {
t.Setenv(key, value)
}
t.Run("Check stale workers with no workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
err := queuer.checkStaleWorkers()
assert.NoError(t, err, "Expected checkStaleWorkers to complete without error when no workers exist")
err = queuer.Stop()
assert.NoError(t, err, "Expected Queuer to stop successfully")
})
t.Run("Check stale workers with fresh workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
queuer.Start(context.Background(), func() {})
defer queuer.Stop()
err := queuer.checkStaleWorkers()
require.NoError(t, err, "Expected checkStaleWorkers to complete without error")
worker, err := queuer.dbWorker.SelectWorker(queuer.worker.RID)
require.NoError(t, err, "Expected to select worker successfully")
assert.Equal(t, model.WorkerStatusRunning, worker.Status, "Expected fresh worker to remain RUNNING")
})
t.Run("Check stale workers marks old workers as offline", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a non running worker with old timestamp
testWorker, err := model.NewWorker("stale-worker", 5)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
_, err = queuer.DB.Exec(
"UPDATE worker SET updated_at = $1, status = $2 WHERE rid = $3",
time.Now().UTC().Add(-1*time.Hour), model.WorkerStatusRunning, insertedWorker.RID,
)
require.NoError(t, err, "Expected to update worker timestamp directly")
// Run the stale check
err = queuer.checkStaleWorkers()
assert.NoError(t, err, "Expected checkStaleWorkers to complete without error")
staleWorkerAfter, err := queuer.dbWorker.SelectWorker(insertedWorker.RID)
require.NoError(t, err, "Expected to select stale worker successfully")
assert.Equal(t, model.WorkerStatusStopped, staleWorkerAfter.Status, "Expected stale worker to be marked as STOPPED")
})
t.Run("Check stale workers ignores already stopped workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker that's already stopped
testWorker, err := model.NewWorker("stopped-worker", 5)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
_, err = queuer.DB.Exec(
"UPDATE worker SET updated_at = $1, status = $2 WHERE rid = $3",
time.Now().Add(-10*time.Minute), model.WorkerStatusStopped, insertedWorker.RID,
)
require.NoError(t, err, "Expected to update worker status directly")
// Run the stale check
err = queuer.checkStaleWorkers()
assert.NoError(t, err, "Expected checkStaleWorkers to complete without error")
offlineWorker, err := queuer.dbWorker.SelectWorker(insertedWorker.RID)
require.NoError(t, err, "Expected to select offline worker successfully")
assert.Equal(t, model.WorkerStatusStopped, offlineWorker.Status, "Expected offline worker to remain STOPPED")
})
}
func TestDeleteStaleWorkers(t *testing.T) {
envs := map[string]string{
"QUEUER_DB_HOST": "localhost",
"QUEUER_DB_PORT": dbPort,
"QUEUER_DB_DATABASE": "database",
"QUEUER_DB_USERNAME": "user",
"QUEUER_DB_PASSWORD": "password",
"QUEUER_DB_SCHEMA": "public",
"QUEUER_DB_SSLMODE": "disable",
}
for key, value := range envs {
t.Setenv(key, value)
}
t.Run("Delete stale workers with no workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
err := queuer.deleteStaleWorkers()
assert.NoError(t, err, "Expected deleteStaleWorkers to complete without error when no workers exist")
err = queuer.Stop()
assert.NoError(t, err, "Expected Queuer to stop successfully")
})
t.Run("Delete stale workers removes old stopped workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and set it to STOPPED with old timestamp
testWorker, err := model.NewWorker("old-stopped-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
// Update worker to STOPPED status and set updated_at to 15 minutes ago (older than 10 minute threshold)
oldTimestamp := time.Now().UTC().Add(-15 * time.Minute)
_, err = queuer.DB.Exec(
"UPDATE worker SET status = $1, updated_at = $2 WHERE rid = $3",
model.WorkerStatusStopped, oldTimestamp, insertedWorker.RID,
)
require.NoError(t, err, "Expected to update worker to old stopped status")
// Run the stale worker deletion
err = queuer.deleteStaleWorkers()
assert.NoError(t, err, "Expected deleteStaleWorkers to complete without error")
// Verify worker was deleted
_, err = queuer.dbWorker.SelectWorker(insertedWorker.RID)
assert.Error(t, err, "Expected worker to be deleted")
})
t.Run("Delete stale workers ignores recent stopped workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and set it to STOPPED with recent timestamp
testWorker, err := model.NewWorker("recent-stopped-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
// Update worker to STOPPED status with recent timestamp (within 10 minute threshold)
insertedWorker.Status = model.WorkerStatusStopped
_, err = queuer.dbWorker.UpdateWorker(insertedWorker)
require.NoError(t, err, "Expected to update worker to stopped status")
// Run the stale worker deletion
err = queuer.deleteStaleWorkers()
assert.NoError(t, err, "Expected deleteStaleWorkers to complete without error")
// Verify worker still exists
worker, err := queuer.dbWorker.SelectWorker(insertedWorker.RID)
require.NoError(t, err, "Expected to select worker successfully")
assert.Equal(t, model.WorkerStatusStopped, worker.Status, "Expected recent stopped worker to remain")
})
t.Run("Delete stale workers ignores active workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and keep it in READY status with old timestamp
testWorker, err := model.NewWorker("old-active-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
// Update worker with old timestamp but keep it READY
oldTimestamp := time.Now().UTC().Add(-15 * time.Minute)
_, err = queuer.DB.Exec(
"UPDATE worker SET updated_at = $1 WHERE rid = $2",
oldTimestamp, insertedWorker.RID,
)
require.NoError(t, err, "Expected to update worker timestamp")
// Run the stale worker deletion
err = queuer.deleteStaleWorkers()
assert.NoError(t, err, "Expected deleteStaleWorkers to complete without error")
// Verify worker still exists (not deleted because it's not STOPPED)
worker, err := queuer.dbWorker.SelectWorker(insertedWorker.RID)
require.NoError(t, err, "Expected to select worker successfully")
assert.Equal(t, model.WorkerStatusReady, worker.Status, "Expected active worker to remain unchanged")
})
}
func TestCheckStaleJobs(t *testing.T) {
envs := map[string]string{
"QUEUER_DB_HOST": "localhost",
"QUEUER_DB_PORT": dbPort,
"QUEUER_DB_DATABASE": "database",
"QUEUER_DB_USERNAME": "user",
"QUEUER_DB_PASSWORD": "password",
"QUEUER_DB_SCHEMA": "public",
"QUEUER_DB_SSLMODE": "disable",
}
for key, value := range envs {
t.Setenv(key, value)
}
t.Run("Check stale jobs with no jobs", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
err := queuer.checkStaleJobs()
assert.NoError(t, err, "Expected checkStaleJobs to complete without error when no jobs exist")
err = queuer.Stop()
assert.NoError(t, err, "Expected Queuer to stop successfully")
})
t.Run("Check stale jobs cancels jobs with stopped workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and set it to STOPPED
testWorker, err := model.NewWorker("stopped-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
insertedWorker.Status = model.WorkerStatusStopped
_, err = queuer.dbWorker.UpdateWorker(insertedWorker)
require.NoError(t, err, "Expected to update worker to STOPPED")
// Create a job assigned to the stopped worker
testJob, err := model.NewJob("test-task", nil, nil)
require.NoError(t, err, "Expected to create test job")
testJob.WorkerRID = insertedWorker.RID
insertedJob, err := queuer.dbJob.InsertJob(testJob)
require.NoError(t, err, "Expected to insert test job")
// Update job to have worker assignment
_, err = queuer.DB.Exec(
"UPDATE job SET worker_rid = $1, status = $2 WHERE rid = $3",
insertedWorker.RID, model.JobStatusRunning, insertedJob.RID,
)
require.NoError(t, err, "Expected to update job worker assignment")
// Run the stale job check
err = queuer.checkStaleJobs()
assert.NoError(t, err, "Expected checkStaleJobs to complete without error")
// Verify job was reset to queued
updatedJob, err := queuer.dbJob.SelectJob(insertedJob.RID)
require.NoError(t, err, "Expected to select job successfully")
assert.Equal(t, model.JobStatusQueued, updatedJob.Status, "Expected job assigned to stopped worker to be reset to queued")
})
t.Run("Check stale jobs ignores jobs with final statuses", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and set it to STOPPED
testWorker, err := model.NewWorker("stopped-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
insertedWorker.Status = model.WorkerStatusStopped
_, err = queuer.dbWorker.UpdateWorker(insertedWorker)
require.NoError(t, err, "Expected to update worker to STOPPED")
// Create a job with final status assigned to the stopped worker
testJob, err := model.NewJob("test-task", nil, nil)
require.NoError(t, err, "Expected to create test job")
testJob.WorkerRID = insertedWorker.RID
insertedJob, err := queuer.dbJob.InsertJob(testJob)
require.NoError(t, err, "Expected to insert test job")
// Update job to have final status
_, err = queuer.DB.Exec(
"UPDATE job SET worker_rid = $1, status = $2 WHERE rid = $3",
insertedWorker.RID, model.JobStatusSucceeded, insertedJob.RID,
)
require.NoError(t, err, "Expected to update job status to final")
// Run the stale job check
err = queuer.checkStaleJobs()
assert.NoError(t, err, "Expected checkStaleJobs to complete without error")
// Verify job status remained unchanged
updatedJob, err := queuer.dbJob.SelectJob(insertedJob.RID)
require.NoError(t, err, "Expected to select job successfully")
assert.Equal(t, model.JobStatusSucceeded, updatedJob.Status, "Expected job with final status to remain unchanged")
})
t.Run("Check stale jobs ignores jobs with ready workers", func(t *testing.T) {
queuer := NewQueuer("test", 10)
require.NotNil(t, queuer, "Expected Queuer to be created successfully")
defer queuer.Stop()
// Create a worker and keep it READY
testWorker, err := model.NewWorker("ready-worker", 3)
require.NoError(t, err, "Expected to create test worker")
insertedWorker, err := queuer.dbWorker.InsertWorker(testWorker)
require.NoError(t, err, "Expected to insert test worker")
// Create a job assigned to the ready worker
testJob, err := model.NewJob("test-task", nil, nil)
require.NoError(t, err, "Expected to create test job")
testJob.WorkerRID = insertedWorker.RID
insertedJob, err := queuer.dbJob.InsertJob(testJob)
require.NoError(t, err, "Expected to insert test job")
// Update job to have worker assignment
_, err = queuer.DB.Exec(
"UPDATE job SET worker_rid = $1, status = $2 WHERE rid = $3",
insertedWorker.RID, model.JobStatusRunning, insertedJob.RID,
)
require.NoError(t, err, "Expected to update job worker assignment")
// Run the stale job check
err = queuer.checkStaleJobs()
assert.NoError(t, err, "Expected checkStaleJobs to complete without error")
// Verify job status remained unchanged
updatedJob, err := queuer.dbJob.SelectJob(insertedJob.RID)
require.NoError(t, err, "Expected to select job successfully")
assert.Equal(t, model.JobStatusRunning, updatedJob.Status, "Expected job assigned to ready worker to remain unchanged")
})
}