Add missing GetHashCode methods

Author: myieye

backend/FwLite/MiniLcm.Tests/RichMultiStringTests.cs

@@ -1,4 +1,3 @@
-using System.Drawing;
 using System.Text.Json;
 using MiniLcm.Tests.AutoFakerHelpers;
 using Soenneker.Utils.AutoBogus;
@@ -10,6 +9,7 @@ namespace MiniLcm.Tests;
 public class RichMultiStringTests
 {
     private static readonly AutoFaker AutoFaker = new(AutoFakerDefault.Config);
+
     [Fact]
     public void RichMultiString_DeserializesSimpleRichString()
     {
@@ -146,6 +146,7 @@ public void RichSpan_EqualityTests()
         var actualSpan = richSpan.Copy();
         richSpan.Should().Be(actualSpan);
         richSpan.Equals(actualSpan).Should().BeTrue();
+        richSpan.GetHashCode().Should().Be(actualSpan.GetHashCode());
     }
 
     [Fact]
@@ -185,6 +186,19 @@ public void RichSpan_EqualityObjectDataMustMatch()
     [Fact]
     public void RichSpan_PerPropertyEqualityTests()
     {
+        static object GenerateDifferentValue(AutoFaker autoFaker, Type type, object? currentValue)
+        {
+            // AutoBogus can return null/default; retry until we actually change the field so the test is a reliable tripwire.
+            for (var attempt = 0; attempt < 20; attempt++)
+            {
+                var value = autoFaker.Generate(type);
+                if (value is null) continue;
+                if (currentValue is null || !currentValue.Equals(value)) return value;
+            }
+
+            throw new InvalidOperationException($"Unable to generate a different value for type '{type.FullName}'.");
+        }
+
         var blankSpan = new RichSpan()
         {
             Text = "test"
@@ -195,11 +209,38 @@ public void RichSpan_PerPropertyEqualityTests()
             if (fieldInfo.FieldType == typeof(RichTextObjectData)) continue;
             var span = new RichSpan() { Text = "test" };
             span.Equals(blankSpan).Should().BeTrue();
-            fieldInfo.SetValue(span, AutoFaker.Generate(fieldInfo.FieldType));
+            var currentValue = fieldInfo.GetValue(span);
+            var differentValue = GenerateDifferentValue(AutoFaker, fieldInfo.FieldType, currentValue);
+            fieldInfo.SetValue(span, differentValue);
             span.Equals(blankSpan).Should().BeFalse("field {0} do not match", fieldInfo.Name);
         }
     }
 
+    [Fact]
+    public void RichString_HashCodeMatchesEquality()
+    {
+        var rs1 = new RichString([new RichSpan() { Text = "test", Ws = "en", Bold = RichTextToggle.On }]);
+        var rs2 = rs1.Copy();
+
+        rs1.Equals(rs2).Should().BeTrue();
+        rs1.GetHashCode().Should().Be(rs2.GetHashCode());
+    }
+
+    [Fact]
+    public void RichString_HashCodeMatchesEquality_ManySeededCases()
+    {
+        var seededFaker = new AutoFaker(AutoFakerDefault.Config);
+        seededFaker.UseSeed(12345);
+        for (var i = 0; i < 200; i++)
+        {
+            var rs1 = seededFaker.Generate<RichString>();
+            var rs2 = rs1.Copy();
+
+            rs1.Equals(rs2).Should().BeTrue();
+            rs1.GetHashCode().Should().Be(rs2.GetHashCode());
+        }
+    }
+
     [Fact]
     public void JsonPatchCanUpdateRichMultiString()
     {

backend/FwLite/MiniLcm/Models/RichString.cs

@@ -103,6 +103,17 @@ public override bool Equals(object? obj)
         if (obj.GetType() != GetType()) return false;
         return Equals((RichString)obj);
     }
+
+    public override int GetHashCode()
+    {
+        var hash = new HashCode();
+        foreach (var span in Spans)
+        {
+            hash.Add(span);
+        }
+
+        return hash.ToHashCode();
+    }
 }
 
 
@@ -300,6 +311,92 @@ public virtual bool Equals(RichSpan? other)
         return EqualsProps(other) && Text == other.Text;
     }
 
+    public override int GetHashCode()
+    {
+        var hash = new HashCode();
+
+        hash.Add(Ws);
+        hash.Add(WsBase);
+        hash.Add(Italic);
+        hash.Add(Bold);
+        hash.Add(Align);
+        hash.Add(Superscript);
+        hash.Add(Underline);
+        hash.Add(FontFamily);
+        hash.Add(FontSize);
+        hash.Add(FontSizeUnit);
+        hash.Add(FontVariations);
+        hash.Add(Offset);
+        hash.Add(OffsetUnit);
+        hash.Add(ForeColor);
+        hash.Add(BackColor);
+        hash.Add(UnderColor);
+        hash.Add(FirstIndent);
+        hash.Add(LeadingIndent);
+        hash.Add(TrailingIndent);
+        hash.Add(SpaceBefore);
+        hash.Add(SpaceAfter);
+        hash.Add(MarginTop);
+        hash.Add(TabDef);
+        hash.Add(LineHeight);
+        hash.Add(LineHeightUnit);
+        hash.Add(ParaColor);
+        hash.Add(SpellCheck);
+        hash.Add(RightToLeft);
+        hash.Add(DirectionDepth);
+        hash.Add(KeepWithNext);
+        hash.Add(KeepTogether);
+        hash.Add(Hyphenate);
+        hash.Add(MaxLines);
+        hash.Add(CellBorderWidth);
+        hash.Add(CellSpacing);
+        hash.Add(CellPadding);
+        hash.Add(Editable);
+        hash.Add(SetRowDefaults);
+        hash.Add(RelLineHeight);
+        hash.Add(WidowOrphan);
+        hash.Add(PadTop);
+        hash.Add(PadBottom);
+        hash.Add(PadLeading);
+        hash.Add(PadTrailing);
+        hash.Add(ParaStyle);
+        hash.Add(CharStyle);
+        hash.Add(NamedStyle);
+        hash.Add(WsStyle);
+        hash.Add(BorderTop);
+        hash.Add(BorderBottom);
+        hash.Add(BorderLeading);
+        hash.Add(BorderTrailing);
+        hash.Add(BorderColor);
+        hash.Add(BulNumScheme);
+        hash.Add(BulNumStartAt);
+        hash.Add(BulNumTxtBef);
+        hash.Add(BulNumTxtAft);
+        hash.Add(BulNumFontInfo);
+        hash.Add(CustomBullet);
+        hash.Add(TabList);
+        hash.Add(TableRule);
+        hash.Add(FieldName);
+        hash.Add(ObjData);
+
+        if (Tags is null)
+        {
+            hash.Add(0);
+        }
+        else
+        {
+            hash.Add(1);
+            foreach (var tag in Tags)
+            {
+                hash.Add(tag);
+            }
+        }
+
+        hash.Add(Text);
+
+        return hash.ToHashCode();
+    }
+
     public bool EqualsProps(RichSpan? other)
     {
         if (other is null) return false;