Skip to content

Commit 224fad8

Browse files
authored
Merge pull request #851 from sir-gon/develop
AI driven upgrade of eslint 8.x to 9.x
2 parents 8bfb52e + 3ac64fb commit 224fad8

File tree

9 files changed

+204
-266
lines changed

9 files changed

+204
-266
lines changed

.github/workflows/eslint-code-scanning.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ jobs:
5050
with:
5151
node-version: 24.x
5252

53-
- name: Install ESLint
53+
- name: Install dependencies
5454
run: |
55-
npm install --include=dev eslint@8.57.1
56-
npm install --include=dev @microsoft/eslint-formatter-sarif@3.0.0
55+
npm ci --legacy-peer-deps
56+
npm install --legacy-peer-deps @microsoft/eslint-formatter-sarif@3.0.0
5757
5858
- name: Test ESLint
5959
run: |

.github/workflows/eslint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ jobs:
4545
with:
4646
node-version: ${{ matrix.node-version }}
4747

48-
- name: Install ESLint
48+
- name: Install dependencies
4949
run: |
50-
npm install --include=dev eslint@8.57.1
50+
npm ci --legacy-peer-deps
5151
5252
- name: Test ESLint
5353
run: |

.github/workflows/node-coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
node-version: 24.x
2626

2727
- name: Install dependencies
28-
run: npm ci --verbose
28+
run: npm ci --legacy-peer-deps
2929

3030
- name: Lint
3131
run: npm run lint

.github/workflows/node-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
node-version: ${{ matrix.node-version }}
3232

3333
- name: Install dependencies
34-
run: npm ci --verbose
34+
run: npm ci --legacy-peer-deps
3535

3636
- name: Run the tests
3737
run: npm run jest:ci

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ COPY ./.yamlignore ${WORKDIR}/
5454
COPY ./.gitignore ${WORKDIR}/
5555

5656
# Dependencies
57-
RUN npm ci --verbose --ignore-scripts
57+
RUN npm ci --legacy-peer-deps --ignore-scripts
5858

5959
CMD ["make", "lint"]
6060
###############################################################################
@@ -122,7 +122,7 @@ COPY ./Makefile ${WORKDIR}/
122122
COPY ./package.json ${WORKDIR}/package.json
123123
COPY ./package-lock.json ${WORKDIR}/package-lock.json
124124

125-
RUN npm ci --verbose --omit=dev --omit=optional --ignore-scripts --no-cache \
125+
RUN npm ci --legacy-peer-deps --omit=dev --omit=optional --ignore-scripts --no-cache \
126126
&& ls -alh
127127

128128
USER node

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ dependencies:
6969
@echo "################################################################################"
7070
@echo "## Dependencies: ###############################################################"
7171
@echo "################################################################################"
72-
test -x ./node_modules || npm install --verbose
72+
test -x ./node_modules || npm install --verbose --legacy-peer-deps
7373
@echo "################################################################################"
7474

7575
lint/json:

eslint.config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ export default [
6363
'no-restricted-syntax': 0,
6464
'no-console': 'off',
6565
'no-underscore-dangle': 0,
66+
// Disable jest rules that require TypeScript type information
67+
'jest/no-error-equal': 0,
68+
'jest/no-unnecessary-assertion': 0,
69+
'jest/valid-expect-with-promise': 0,
6670

6771
'no-plusplus': [
6872
'error',

0 commit comments

Comments
 (0)