Sometimes the wrong cube map texture is used for the skybox for a moment #414
Description
It corrects quickly, but sometimes you'll see, say a planet texture used for the skybox texture.
I think it happens immediately after transiting a warp gate.
You can trigger it pretty reliably by the following procedure:
Start up snis_client, and choose the wrong star system (say, DEFAULT, when the correct one is ZOLON). It will dump you into DEFAULT, but then right away slam you into ZOLON, and there's a good chance the skybox will be the wrong texture for a moment.
What I think is happening is it loads all the textures for DEFAULT, texture_finished_loading[] is 1 for all the textures, then you slam into ZOLON, and it re-uses the textures, but there are only 4 threads to load them, maybe the skybox isn't among the first 4, but rather say, 4 big planet textures, so they take a moment to load, meanwhile the skybox is over there using the wrong texture, an old planet texture left over from DEFAULT.
Maybe the fix is to mark "expired" textures as not loaded.
Edit: marking expired textures as not loaded did not fix the problem, and introduced some other problems.
Maybe when you start off in the wrong solar system, it starts slamming you into the correct solar system before it has even finished loading the textures for the first one, but they are already queued up to be loaded, so they get loaded, but queued up behind them are requests to load the correct textures for the new solarsystem, so the wrong textures don't stick around very long.