client is larger than screen dimensions

[mejo13]

Describe the bug

single clients occupying the whole screen space (but aren't fullscreen) aren't shrunk to account for border size.

To Reproduce

compile a binary from the minimal example and open a client. it should be slightly bigger than the screen itself is.

Expected behavior

client should be shrunk to account for the border size.

Versions & OS Details

• OS: linux
• Distribution: Arch
• OS Version: 6.15.3-arch1-1
• Penrose Version: f95da04

Additional context

i fixed this with this commit. but this requires an additional request to the x server per client when calling position_clients. so i tried something else and introduced an additional field to state.client_set, in this commit (in another branch), to keep track of the fullscreen state of clients. i'm unsure what the right approach is here or if something else entirely is better.
what do you think about this?

[sminez]

As with #329, the problem with your proposed fix here is that you are adding logic relating to an extension (full screen state) to the core data structures.

I'm also not sure I fully understand the issue here, as the maximum size for a client window should be the size of the screen itself for the built in layouts, but really the author of the layout is free to specify whatever size and position they wish. So in the general case, you will always have the possibility of clients being sized in a way that oversteps the bounds of the screen.

Rather than modify the core logic to handle this, I think what you are after is a layout hook that clamps the maximum size of clients.

[mejo13]

I made some screenshots to show what i mean. They are taken with the minimal config from examples with no changes, so that's the MainAndStack layout, and penrose is on the current develop branch. The first screenshot shows the main monitor with one client. The second and third screenshots show both monitors of my current setup. On the second screenshot the right side border from the client on the first monitor is visible on the second monitor. On the third screenshot a client on the second monitor is rendered over the border from the client on the first monitor.

Tested with only one monitor attached to my pc or some other layouts, it shows the same behaviour.

I assume that most people use a status bar or gaps which both prevent this from happening as no client occupies the whole penrose screen except for fullscreen clients or maybe big regular floating clients. But while setting up a new system i used this for a while, got used to it and thought about keeping it in some form. I thought about making the status bar and the gaps toggleable if possible, but that's another story.

[smeily207]

Hello
I can see the same issue as @mejo13 that the window is slightly to big for the screen with the default config.
After some testing the problem seems to be that the border-width is not calculated into the window size anymore, which then pushes the window out of the screen border.
I noticed this problem started with the change to version 0.4.0

[CMOISDEAD]

Hello, I’m experiencing the same issue.
When only one client is open, the window becomes larger than the screen, as shown below.

This does not happen when multiple clients are open. The issue appears again when using a monocle layout or when there is only a single client.

Default configuration (issue presente)

let gaps = 1;
let config = add_ewmh_hooks(Config {
    ..Config::default()
});

let conn = RustConn::new()?;
let key_bindings = parse_keybindings_with_xmodmap(raw_key_bindings())?;
let wm = WindowManager::new(config, key_bindings, mouse_bindings(), conn)?;

wm.run()

I was able to work around this by adding gaps using SpacingHook. After doing this, the issue no longer occurs.

Configuration (no issue)

let gaps = 1;
let config = add_ewmh_hooks(Config {
    border_width: 1,
    focused_border: Color::try_from("#0000ff").unwrap(),
    normal_border: Color::try_from("#121212").unwrap(),
    focus_follow_mouse: true,
    default_layouts: layouts(),
    layout_hook: Some(Box::new(SpacingHook {
        inner_px: gaps,
        outer_px: gaps,
        top_px: gaps,
        bottom_px: gaps,
    })),
    ..Config::default()
});

Hope this helps someone else.

[sminez]

@mejo13 Sorry for not taking a look at this sooner. The comment from @CMOISDEAD last week dropped this bug back into my GitHub notifications and I've had another look at the fixes you initially proposed back in June. Now that the refactor of the backend API traits has been merged, a variant of your fix fits pretty cleanly into the existing logic for positioning clients without introducing X11 specific logic or tracking additional information in State. It does still result in additional call to the X server per client when positioning though which isn't ideal, so I might take a look at adding a client message handler for storing that state internally as well.