Skip to content

Commit 0e7bcc5

Browse files
committed
Remove setting explicit pool_idle_timeout since default is already 90s
1 parent 07bb796 commit 0e7bcc5

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.changelog/hyper-defaults.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,9 @@ applies_to:
44
authors:
55
- landonxjames
66
references:
7-
- smithy-rs#4274
7+
- smithy-rs#4282
88
breaking: false
99
new_feature: false
1010
bug_fix: true
1111
---
12-
Set the `pool_idle_timeout` for the default Hyper client to 90 seconds. This aligns with the behavior of the hyper 0.14.x client that was previously the default.
13-
https://github.com/smithy-lang/smithy-rs/issues/4282
12+
Set the `pool_timer` for the default Hyper client. This is required to allow the `pool_idle_timeout` to work. Now idle connections will be released by the pool after 90 seconds.

rust-runtime/aws-smithy-http-client/src/client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@ impl<Any> ConnectorBuilder<Any> {
195195
{
196196
let client_builder = self.client_builder.unwrap_or_else(|| {
197197
let mut builder = hyper_util::client::legacy::Builder::new(TokioExecutor::new());
198+
// Explicitly setting the pool_timer is required for connection timeouts to work.
198199
builder.pool_timer(TokioTimer::new());
199-
builder.pool_idle_timeout(Duration::from_secs(90));
200200

201201
builder
202202
});

0 commit comments

Comments
 (0)