Commit e394ad8
The [earlier PR](#4010),
which ensured that a Smithy shape named `Result` does not conflict with
the Rust type `Result`, had a bug in `TSApplicationGenerator`. The
`rustTemplateBlock` was using `#{Result}` but `preludeScope` was not
passed in as a parameter.
This bug can be addressed in two ways:
1. Pass `*RuntimeType.preludeScope` to the `rustBlockTemplate` call
2. Remove `#{Result}` from `rustBlockTemplate` and continue using
`Result<>`
This PR implements the second approach because:
1. `TSApplicationGenerator` is slated for deprecation
2. The CI step `CI / PR Bot / Generate diff and upload to S3
(pull_request)` currently fails when comparing codegen between HEAD and
this version. Removing `#{Result}` is the most reliable way to avoid
parameter-passing issues with `rustBlockTemplate`
Co-authored-by: Fahad Zubair <fahadzub@amazon.com>
1 parent bb92aef commit e394ad8
File tree
1 file changed
+1
-1
lines changed- codegen-server/typescript/src/main/kotlin/software/amazon/smithy/rust/codegen/server/typescript/smithy/generators
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
0 commit comments