diff --git a/.changeset/fix-schema-trait-computed-keys.md b/.changeset/fix-schema-trait-computed-keys.md new file mode 100644 index 00000000000..3ac6d02f034 --- /dev/null +++ b/.changeset/fix-schema-trait-computed-keys.md @@ -0,0 +1,5 @@ +--- +"@smithy/core": patch +--- + +fix(codegen): use literal string keys in SchemaTraitWriter to fix esbuild tree-shaking diff --git a/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriter.java b/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriter.java index f7e3951345f..c6e9bbf6361 100644 --- a/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriter.java +++ b/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriter.java @@ -86,8 +86,8 @@ private void writeTraitsObject() { } buffer.append( """ - [%s]: %s,\s""".formatted( - stringStore.var(shapeId.getName()), + "%s": %s,\s""".formatted( + shapeId.getName(), traitGenerator.serializeTraitData(trait, stringStore) ) ); diff --git a/smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriterTest.java b/smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriterTest.java index 36b2566d0d0..929d91524b1 100644 --- a/smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriterTest.java +++ b/smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/schema/SchemaTraitWriterTest.java @@ -40,7 +40,7 @@ void testToString() { String codeGeneration = subject.toString(); assertEquals( """ - { [_s]: 1 }""", + { "streaming": 1 }""", codeGeneration ); }