From 5e6f74196a3639da8c1180dacfdbb029ea15a058 Mon Sep 17 00:00:00 2001 From: 0marperez Date: Mon, 23 Feb 2026 16:00:10 -0700 Subject: [PATCH 1/4] Remove null dense collection protocol tests --- ...243c73ed26a3a329d679f9e1554798714c5f1.json | 7 +++++ .../model/restJson1/json-maps.smithy | 27 ------------------- .../model/rpcv2Cbor/cbor-maps.smithy | 21 --------------- 3 files changed, 7 insertions(+), 48 deletions(-) create mode 100644 .changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json diff --git a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json new file mode 100644 index 00000000000..01e1f2aaee8 --- /dev/null +++ b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json @@ -0,0 +1,7 @@ +{ + "type": "break", + "description": "Remove RpcV2CborDeserializesDenseSetMapAndSkipsNull and RestJsonDeserializesDenseSetMapAndSkipsNull protocol tests", + "pull_requests": [ + "[#2944](https://github.com/smithy-lang/smithy/pull/2944)" + ] +} diff --git a/smithy-aws-protocol-tests/model/restJson1/json-maps.smithy b/smithy-aws-protocol-tests/model/restJson1/json-maps.smithy index 814c38a8f00..b715865e52c 100644 --- a/smithy-aws-protocol-tests/model/restJson1/json-maps.smithy +++ b/smithy-aws-protocol-tests/model/restJson1/json-maps.smithy @@ -187,33 +187,6 @@ apply JsonMaps @httpResponseTests([ "y": ["a", "b"] } } - }, - { - id: "RestJsonDeserializesDenseSetMapAndSkipsNull", - documentation: """ - Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD - drop the null key-value pair.""", - protocol: restJson1, - appliesTo: "client", - code: 200, - body: """ - { - "denseSetMap": { - "x": [], - "y": ["a", "b"], - "z": null - } - }""", - bodyMediaType: "application/json", - headers: { - "Content-Type": "application/json" - }, - params: { - "denseSetMap": { - "x": [], - "y": ["a", "b"] - } - } } ]) diff --git a/smithy-protocol-tests/model/rpcv2Cbor/cbor-maps.smithy b/smithy-protocol-tests/model/rpcv2Cbor/cbor-maps.smithy index 6013433f089..ea1c57ab297 100644 --- a/smithy-protocol-tests/model/rpcv2Cbor/cbor-maps.smithy +++ b/smithy-protocol-tests/model/rpcv2Cbor/cbor-maps.smithy @@ -156,27 +156,6 @@ apply RpcV2CborDenseMaps @httpResponseTests([ "y": ["a", "b"] } } - }, - { - id: "RpcV2CborDeserializesDenseSetMapAndSkipsNull", - documentation: """ - Clients SHOULD tolerate seeing a null value in a dense map, and they SHOULD - drop the null key-value pair.""", - protocol: rpcv2Cbor, - appliesTo: "client", - code: 200, - body: "oWtkZW5zZVNldE1hcKNheIBheYJhYWFiYXr2", - bodyMediaType: "application/cbor", - headers: { - "smithy-protocol": "rpc-v2-cbor", - "Content-Type": "application/cbor" - }, - params: { - "denseSetMap": { - "x": [], - "y": ["a", "b"] - } - } } ]) From bb7eeb85bbfc9faabed34f68cee26d3263c8bb88 Mon Sep 17 00:00:00 2001 From: 0marperez Date: Mon, 23 Feb 2026 16:04:28 -0700 Subject: [PATCH 2/4] Update changelog with PR number --- .../feature-879243c73ed26a3a329d679f9e1554798714c5f1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json index 01e1f2aaee8..5833f5243f7 100644 --- a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json +++ b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json @@ -2,6 +2,6 @@ "type": "break", "description": "Remove RpcV2CborDeserializesDenseSetMapAndSkipsNull and RestJsonDeserializesDenseSetMapAndSkipsNull protocol tests", "pull_requests": [ - "[#2944](https://github.com/smithy-lang/smithy/pull/2944)" + "[#2972](https://github.com/smithy-lang/smithy/pull/2972)" ] } From 5b53ede4e228667e8ee4309340fdd592a4033765 Mon Sep 17 00:00:00 2001 From: 0marperez <60363173+0marperez@users.noreply.github.com> Date: Tue, 24 Feb 2026 14:34:18 -0500 Subject: [PATCH 3/4] Update .changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json Co-authored-by: Manuel Sugawara --- .../feature-879243c73ed26a3a329d679f9e1554798714c5f1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json index 5833f5243f7..f48889bb461 100644 --- a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json +++ b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json @@ -1,5 +1,5 @@ { - "type": "break", + "type": "other", "description": "Remove RpcV2CborDeserializesDenseSetMapAndSkipsNull and RestJsonDeserializesDenseSetMapAndSkipsNull protocol tests", "pull_requests": [ "[#2972](https://github.com/smithy-lang/smithy/pull/2972)" From 80aa6e6527d5637d42308d37f6c7a7e805e32f6b Mon Sep 17 00:00:00 2001 From: 0marperez <60363173+0marperez@users.noreply.github.com> Date: Tue, 24 Feb 2026 14:34:32 -0500 Subject: [PATCH 4/4] Update .changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json Co-authored-by: Manuel Sugawara --- .../feature-879243c73ed26a3a329d679f9e1554798714c5f1.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json index f48889bb461..213e9e6afb9 100644 --- a/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json +++ b/.changes/next-release/feature-879243c73ed26a3a329d679f9e1554798714c5f1.json @@ -1,6 +1,6 @@ { "type": "other", - "description": "Remove RpcV2CborDeserializesDenseSetMapAndSkipsNull and RestJsonDeserializesDenseSetMapAndSkipsNull protocol tests", + "description": "Removed protocol tests for skipping null values in dense collections. This behavior can silently drop data. SDKs that cannot preserve null values should raise an exception instead", "pull_requests": [ "[#2972](https://github.com/smithy-lang/smithy/pull/2972)" ]