refactor: Refactor note save change logic and update UI tests

- Introduce `ShowCheckSaveChangeDialog` action to explicitly handle the display of the save confirmation dialog.
- Update `NoteViewModel` to separate the logic for checking changes from the logic for showing the save dialog, moving navigation into `showSaveChangesDialog`.
- Refactor `BaseTestCase` to use `inline` functions and expose `commonDialog` to improve test performance and accessibility.
- Update `CreateNoteWhileSelectedTestCase` to follow the new UI navigation and assertion flow, ensuring the note state is preserved when canceling the save dialog.
- Update `NoteDetail` to trigger the new `ShowCheckSaveChangeDialog` action.

Author: softartdev

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/note/NoteResult.kt

@@ -15,4 +15,5 @@ sealed interface NoteAction {
     data object Edit : NoteAction
     data object Delete : NoteAction
     data class CheckSaveChange(val title: String, val text: CharSequence) : NoteAction
+    data class ShowCheckSaveChangeDialog(val title: String, val text: CharSequence) : NoteAction
 }

core/presentation/src/commonMain/kotlin/com/softartdev/notedelight/presentation/note/NoteViewModel.kt

@@ -65,6 +65,7 @@ class NoteViewModel(
         is NoteAction.Edit -> editTitle()
         is NoteAction.Delete -> subscribeToDeleteNote()
         is NoteAction.CheckSaveChange -> checkSaveChange(title = action.title, text = action.text.toString())
+        is NoteAction.ShowCheckSaveChangeDialog -> showSaveChangesDialog(title = action.title, text = action.text.toString())
     }
 
     private fun createOrLoadNote() = when (noteId) {
@@ -154,10 +155,7 @@ class NoteViewModel(
             val changed: Boolean = isChanged(noteId, noteTitle, text)
             val empty: Boolean = isEmpty(noteId)
             when {
-                changed -> {
-                    router.navigate(route = AppNavGraph.SaveChangesDialog)
-                    subscribeToSaveNote(title, text)
-                }
+                changed -> showSaveChangesDialog(title, text)
                 empty -> deleteNoteForResult()
                 else -> adaptiveNavigateBack()
             }
@@ -168,9 +166,10 @@ class NoteViewModel(
         }
     }
 
-    private fun subscribeToSaveNote(title: String?, text: String) = viewModelScope.launch {
+    private fun showSaveChangesDialog(title: String?, text: String) = viewModelScope.launch {
         mutableStateFlow.update(NoteResult::showLoading)
         try {
+            router.navigate(route = AppNavGraph.SaveChangesDialog)
             logger.d { "Subscribe to save note dialog channel" }
             val doSave: Boolean? = withContext(coroutineDispatchers.io) {
                 SaveNoteUseCase.dialogChannel.receive()

ui/shared/src/commonMain/kotlin/com/softartdev/notedelight/ui/main/NoteDetail.kt

@@ -93,7 +93,7 @@ fun NoteDetail(
     }
     LaunchedEffect(checkSaveChangeChannel) {
         checkSaveChangeChannel.receiveAsFlow().collect {
-            onAction(NoteAction.CheckSaveChange(titleState.value, textState.text))
+            onAction(NoteAction.ShowCheckSaveChangeDialog(titleState.value, textState.text))
         }
     }
     NoteDetailBody(

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/BaseTestCase.kt

@@ -18,35 +18,35 @@ import com.softartdev.notedelight.ui.screen.dialog.LanguageDialog
 
 abstract class BaseTestCase(val composeUiTest: ComposeUiTest) {
 
-    private val commonDialog: CommonDialog = CommonDialogImpl(composeUiTest)
+    val commonDialog: CommonDialog = CommonDialogImpl(composeUiTest)
 
-    suspend fun signInScreen(block: suspend SignInScreen.() -> Unit) =
+    suspend inline fun signInScreen(block: suspend SignInScreen.() -> Unit) =
         SignInScreen(composeUiTest).block()
 
-    suspend fun mainTestScreen(block: suspend MainTestScreen.() -> Unit) =
+    suspend inline fun mainTestScreen(block: suspend MainTestScreen.() -> Unit) =
         MainTestScreen(composeUiTest).block()
 
-    suspend fun noteScreen(block: suspend NoteScreen.() -> Unit) =
+    suspend inline fun noteScreen(block: suspend NoteScreen.() -> Unit) =
         NoteScreen(composeUiTest).block()
 
-    suspend fun settingsTestScreen(block: suspend SettingsTestScreen.() -> Unit) =
+    suspend inline fun settingsTestScreen(block: suspend SettingsTestScreen.() -> Unit) =
         SettingsTestScreen(composeUiTest).block()
 
-    suspend fun commonDialog(block: suspend CommonDialog.() -> Unit) =
+    suspend inline fun commonDialog(block: suspend CommonDialog.() -> Unit) =
         commonDialog.block()
 
-    suspend fun editTitleDialog(block: suspend EditTitleDialog.() -> Unit) =
+    suspend inline fun editTitleDialog(block: suspend EditTitleDialog.() -> Unit) =
         EditTitleDialog(commonDialog).block()
 
-    suspend fun confirmPasswordDialog(block: suspend ConfirmPasswordDialog.() -> Unit) =
+    suspend inline fun confirmPasswordDialog(block: suspend ConfirmPasswordDialog.() -> Unit) =
         ConfirmPasswordDialog(commonDialog).block()
 
-    suspend fun enterPasswordDialog(block: suspend EnterPasswordDialog.() -> Unit) =
+    suspend inline fun enterPasswordDialog(block: suspend EnterPasswordDialog.() -> Unit) =
         EnterPasswordDialog(commonDialog).block()
 
-    suspend fun changePasswordDialog(block: suspend ChangePasswordDialog.() -> Unit) =
+    suspend inline fun changePasswordDialog(block: suspend ChangePasswordDialog.() -> Unit) =
         ChangePasswordDialog(commonDialog).block()
 
-    suspend fun languageDialog(block: suspend LanguageDialog.() -> Unit) =
+    suspend inline fun languageDialog(block: suspend LanguageDialog.() -> Unit) =
         LanguageDialog(commonDialog).block()
 }

ui/test/src/commonMain/kotlin/com/softartdev/notedelight/ui/cases/CreateNoteWhileSelectedTestCase.kt

@@ -5,13 +5,12 @@ package com.softartdev.notedelight.ui.cases
 import androidx.compose.ui.test.ComposeUiTest
 import androidx.compose.ui.test.ExperimentalTestApi
 import androidx.compose.ui.test.assertTextContains
-import androidx.compose.ui.test.assertIsDisplayed
 import androidx.compose.ui.test.onNodeWithTag
 import androidx.compose.ui.test.onNodeWithText
 import androidx.compose.ui.test.performClick
 import androidx.compose.ui.test.performTextInput
 import com.softartdev.notedelight.ui.BaseTestCase
-import com.softartdev.notedelight.ui.main.NOTE_TEXT_FIELD_TAG
+import com.softartdev.notedelight.ui.screen.MainTestScreen
 import com.softartdev.notedelight.util.CREATE_NOTE_FAB_TAG
 import com.softartdev.notedelight.waitAssert
 import com.softartdev.notedelight.waitUntilDisplayed
@@ -29,7 +28,6 @@ class CreateNoteWhileSelectedTestCase(
 
     override fun invoke() = runTest {
         val noteText = Uuid.random().toString().substring(0, 30)
-
         mainTestScreen {
             composeUiTest.waitUntilDisplayed("fab", blockSNI = ::fabSNI)
             fabSNI.performClick()
@@ -40,22 +38,24 @@ class CreateNoteWhileSelectedTestCase(
             composeUiTest.waitAssert("note text input applied") {
                 textFieldSNI.assertTextContains(noteText)
             }
+            saveNoteMenuButtonSNI.performClick()
+        }
+        MainTestScreen.noteItemTitleText = noteText
+        mainTestScreen {
+            val fabVisible = runCatching(this@mainTestScreen::fabSNI).isSuccess // `assertIsDisplayed` invokes in getter
+            if (!fabVisible) return@runTest
+            composeUiTest.waitUntilDisplayed("noteListItem", blockSNI = ::noteListItemSNI)
+            noteListItemSNI.performClick()
         }
-
-        val fabVisible = runCatching {
-            composeUiTest.onNodeWithTag(CREATE_NOTE_FAB_TAG).assertIsDisplayed()
-        }.isSuccess
-        if (!fabVisible) return@runTest
-
         composeUiTest.onNodeWithTag(CREATE_NOTE_FAB_TAG).performClick()
-
         commonDialog {
             composeUiTest.waitUntilDisplayed("saveChangesDialogYes", blockSNI = ::confirmDialogButtonSNI)
         }
         composeUiTest.onNodeWithText(getString(Res.string.cancel)).performClick()
-
-        composeUiTest.waitAssert("note text preserved") {
-            composeUiTest.onNodeWithTag(NOTE_TEXT_FIELD_TAG).assertTextContains(noteText)
+        noteScreen {
+            composeUiTest.waitAssert("note text preserved") {
+                textFieldSNI.assertTextContains(noteText)
+            }
         }
     }
 }