From b9497b25cc17caba3b4f6a177b301054a0cfdffe Mon Sep 17 00:00:00 2001 From: etichy Date: Tue, 2 Dec 2025 11:55:46 +0100 Subject: [PATCH] Enable collect histograms by default --- .../gateway-config-map_test.yaml.snap | 5 --- ...ollector-config-map-fargate_test.yaml.snap | 8 ---- ...etrics-collector-config-map_test.yaml.snap | 24 ----------- ...etrics-discovery-config-map_test.yaml.snap | 6 --- ...ollector-config-map-windows_test.yaml.snap | 14 ------- .../node-collector-config-map_test.yaml.snap | 41 ------------------- deploy/helm/values.yaml | 2 +- 7 files changed, 1 insertion(+), 99 deletions(-) diff --git a/deploy/helm/tests/__snapshot__/gateway-config-map_test.yaml.snap b/deploy/helm/tests/__snapshot__/gateway-config-map_test.yaml.snap index be6e725b..fe00a56c 100644 --- a/deploy/helm/tests/__snapshot__/gateway-config-map_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/gateway-config-map_test.yaml.snap @@ -414,10 +414,6 @@ Gateway config should match snapshot when using default values: send_batch_max_size: 1024 send_batch_size: 1024 timeout: 1s - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM filter/obi-self-loop-relationships: error_mode: ignore metrics: @@ -822,7 +818,6 @@ Gateway config should match snapshot when using default values: - forward/metrics_common processors: - memory_limiter - - filter/histograms receivers: - routing/metrics metrics/common_in: diff --git a/deploy/helm/tests/__snapshot__/metrics-collector-config-map-fargate_test.yaml.snap b/deploy/helm/tests/__snapshot__/metrics-collector-config-map-fargate_test.yaml.snap index 5705fcff..ef1c5a65 100644 --- a/deploy/helm/tests/__snapshot__/metrics-collector-config-map-fargate_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/metrics-collector-config-map-fargate_test.yaml.snap @@ -225,13 +225,6 @@ Metrics config should match snapshot when using default values: - k8s.node.network.packets_transmitted - k8s.node.network.receive_packets_dropped - k8s.node.network.transmit_packets_dropped - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds" - or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes" - or name == "k8s.istio_request_duration_milliseconds" ) filter/kube-state-metrics: metrics: metric: @@ -1715,7 +1708,6 @@ Metrics config should match snapshot when using default values: - otlp processors: - memory_limiter - - filter/histograms - transform/scope - batch receivers: diff --git a/deploy/helm/tests/__snapshot__/metrics-collector-config-map_test.yaml.snap b/deploy/helm/tests/__snapshot__/metrics-collector-config-map_test.yaml.snap index c8e99326..f8b48370 100644 --- a/deploy/helm/tests/__snapshot__/metrics-collector-config-map_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/metrics-collector-config-map_test.yaml.snap @@ -225,13 +225,6 @@ Metrics config should match snapshot when fargate is enabled: - k8s.node.network.packets_transmitted - k8s.node.network.receive_packets_dropped - k8s.node.network.transmit_packets_dropped - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds" - or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes" - or name == "k8s.istio_request_duration_milliseconds" ) filter/kube-state-metrics: metrics: metric: @@ -1715,7 +1708,6 @@ Metrics config should match snapshot when fargate is enabled: - otlp processors: - memory_limiter - - filter/histograms - transform/scope - batch receivers: @@ -2030,13 +2022,6 @@ Metrics config should match snapshot when using Prometheus url with extra_scrape - k8s.node.network.packets_transmitted - k8s.node.network.receive_packets_dropped - k8s.node.network.transmit_packets_dropped - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds" - or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes" - or name == "k8s.istio_request_duration_milliseconds" ) filter/kube-state-metrics: metrics: metric: @@ -3455,7 +3440,6 @@ Metrics config should match snapshot when using Prometheus url with extra_scrape - otlp processors: - memory_limiter - - filter/histograms - transform/scope - batch receivers: @@ -3777,13 +3761,6 @@ Metrics config should match snapshot when using default values: - k8s.node.network.packets_transmitted - k8s.node.network.receive_packets_dropped - k8s.node.network.transmit_packets_dropped - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not( name == "k8s.apiserver_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.coredns_dns_request_duration_seconds" - or name == "k8s.coredns_dns_request_size_bytes" or name == "k8s.coredns_dns_response_size_bytes" - or name == "k8s.istio_request_duration_milliseconds" ) filter/kube-state-metrics: metrics: metric: @@ -5187,7 +5164,6 @@ Metrics config should match snapshot when using default values: - otlp processors: - memory_limiter - - filter/histograms - transform/scope - batch receivers: diff --git a/deploy/helm/tests/__snapshot__/metrics-discovery-config-map_test.yaml.snap b/deploy/helm/tests/__snapshot__/metrics-discovery-config-map_test.yaml.snap index 3a33f00e..2da603c6 100644 --- a/deploy/helm/tests/__snapshot__/metrics-discovery-config-map_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/metrics-discovery-config-map_test.yaml.snap @@ -383,11 +383,6 @@ Metrics discovery config should match snapshot when Fargate is enabled: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -774,7 +769,6 @@ Metrics discovery config should match snapshot when Fargate is enabled: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope diff --git a/deploy/helm/tests/__snapshot__/node-collector-config-map-windows_test.yaml.snap b/deploy/helm/tests/__snapshot__/node-collector-config-map-windows_test.yaml.snap index 2b2605c9..f408b0d8 100644 --- a/deploy/helm/tests/__snapshot__/node-collector-config-map-windows_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/node-collector-config-map-windows_test.yaml.snap @@ -482,12 +482,6 @@ Node collector config for windows nodes should match snapshot when using default - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -1681,7 +1675,6 @@ Node collector config for windows nodes should match snapshot when using default - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope @@ -2300,12 +2293,6 @@ Node collector config for windows nodes should match snapshot when using legacy - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -3588,7 +3575,6 @@ Node collector config for windows nodes should match snapshot when using legacy - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope diff --git a/deploy/helm/tests/__snapshot__/node-collector-config-map_test.yaml.snap b/deploy/helm/tests/__snapshot__/node-collector-config-map_test.yaml.snap index 4f2293c6..41812566 100644 --- a/deploy/helm/tests/__snapshot__/node-collector-config-map_test.yaml.snap +++ b/deploy/helm/tests/__snapshot__/node-collector-config-map_test.yaml.snap @@ -482,12 +482,6 @@ Custom logs filter with new syntax: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -1722,7 +1716,6 @@ Custom logs filter with new syntax: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope @@ -2341,12 +2334,6 @@ Custom logs filter with old syntax: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -3665,7 +3652,6 @@ Custom logs filter with old syntax: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope @@ -4284,12 +4270,6 @@ Node collector config should match snapshot when autodiscovery is disabled: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -5459,7 +5439,6 @@ Node collector config should match snapshot when autodiscovery is disabled: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope @@ -6075,12 +6054,6 @@ Node collector config should match snapshot when fargate is enabled: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -7255,7 +7228,6 @@ Node collector config should match snapshot when fargate is enabled: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope @@ -7842,12 +7814,6 @@ Node collector config should match snapshot when fargate is enabled and autodisc - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -9545,12 +9511,6 @@ Node collector config should match snapshot when using default values: - k8s.istio_requests.rate - k8s.istio_tcp_sent_bytes.rate - k8s.istio_tcp_received_bytes.rate - filter/histograms: - metrics: - metric: - - type == METRIC_DATA_TYPE_HISTOGRAM and not(name == "k8s.rest_client_request_duration_seconds" - or name == "k8s.workqueue_queue_duration_seconds" or name == "k8s.etcd_disk_wal_fsync_duration_seconds" - or name == "k8s.etcd_disk_backend_commit_duration_seconds") filter/keep-entity-state-events: logs: log_record: @@ -10780,7 +10740,6 @@ Node collector config should match snapshot when using default values: - otlp processors: - memory_limiter - - filter/histograms - k8sattributes - filter/remove_temporary_metrics - transform/scope diff --git a/deploy/helm/values.yaml b/deploy/helm/values.yaml index e2c2b689..375a5c6f 100644 --- a/deploy/helm/values.yaml +++ b/deploy/helm/values.yaml @@ -91,7 +91,7 @@ otel: # Filter out histogram metrics before sending to SWO # Enabled by default due to SWO current limitations. - filter_histograms: true + filter_histograms: false # configuration for metric discovery autodiscovery: