-
Notifications
You must be signed in to change notification settings - Fork 183
Open
Labels
backlogRaised on the CNX backlogRaised on the CNX backlogbugSomething isn't workingSomething isn't working
Description
Prerequisites
- I read the contribution guidelines
- I checked the documentation and found no answer.
- I checked existing issues and found no similar issue.
- I checked the community forum for related discussions and found no answer.
- I'm reporting the issue to the correct repository (see also speckle-server, speckle-sharp, specklepy, speckle-docs, and others)
What package are you referring to?
speckle-sharp (revit)
Describe the bug
START_JOIN_CUTBACKandEND_JOIN_CUTBACKparameters are not being set on receive into Revit for framing.
To Reproduce
- Send beam (with valid values for cutback parameters) and columns to Speckle - note the
START_JOIN_CUTBACKandEND_JOIN_CUTBACKparameters do get sent - Receive objects into a new model, noting that cutback parameters get set to default values (0mm for beams and 12.7mm for bracing iirc).
Expected behavior
Cutback parameter values should be set.
Screenshots
System Info
If applicable, please fill in the below details - they help a lot!
Desktop (please complete the following information):
- OS: Windows 10
Failure Logs
Additional context
I did some extra scoping of the issue and thought I'd share what insight I have:
- The parameters on the beam that is created (fetched here) has parameters matching those created for a beam that is set to
disallow joins, i.e. missing theSTART_JOIN_CUTBACKandEND_JOIN_CUTBACKparameters (plus two others not relevant to this issue). - My initial thought was that applying
allow joinis done somewhere later in the operation and therefore the parameter is not yet accessible on the element during the conversion method. - However, I can access/set the cutback parameters on the object explicitly in the conversion method utilizing
TrySetParamon the explicit parameterBuiltInParameter.START_JOIN_CUTBACK.
Proposed Solution (if any)
- Simple fix would just be to try setting these parameters on the beam/brace conversion methods separate to the parameters that are set in the Utils method. I added a quickfix to Arup's repo for this to support a project workflow in the interim to a more robust solution.
- Alternatively a better understanding of why these parameters don't surface in the Utils method.
Optional: Affected Projects
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
backlogRaised on the CNX backlogRaised on the CNX backlogbugSomething isn't workingSomething isn't working