Skip to content

Comments

Update docs: verify installation and simple system tutorial#1151

Merged
nhniina merged 7 commits intomasterfrom
JustinasJas-patch-1
Feb 14, 2025
Merged

Update docs: verify installation and simple system tutorial#1151
nhniina merged 7 commits intomasterfrom
JustinasJas-patch-1

Conversation

@JustinasJas
Copy link
Contributor

@JustinasJas JustinasJas commented Dec 20, 2024

Power units in MW (simple system tutorial).

Checklist before merging

  • Documentation is up-to-date
  • Unit tests have been added/updated accordingly
  • Code has been formatted according to SpineOpt's style
  • Unit tests pass

Power units in MW (simple system tutorial).
@JustinasJas JustinasJas requested a review from nhniina December 20, 2024 11:29
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (f6bf05a) to head (b9e1252).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files         143      143           
  Lines        4135     4135           
=======================================
  Hits         3612     3612           
  Misses        523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada
Copy link
Member

@JustinasJas Thanks for the PR. One question: the title in the PR is WIP (work in progress), are you planning to add more changes? if so, please change the PR to a draft. Otherwise, let us know to merge your changes.

JustinasJas and others added 6 commits February 7, 2025 18:06
Updating Simple system tutorial instructions based on observations from test teaching session in Tampere University.
Updating Recommended workflow page instructions based on observations from test teaching session in Tampere University.
Clarifying unintuitive terms.
Clarifying unintuitive entity present in the figure
@nhniina nhniina changed the title WIP: Update simple_system.md Update docs: verify installation and simple system tutorial Feb 14, 2025
Copy link
Collaborator

@nhniina nhniina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested edits clarify the instructions. I made some additional edits.

@nhniina nhniina merged commit f662cc1 into master Feb 14, 2025
7 checks passed
@nhniina nhniina deleted the JustinasJas-patch-1 branch February 14, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants