Use align_variable_duration_unit function instead of convert_to_days#1154
Merged
Use align_variable_duration_unit function instead of convert_to_days#1154
align_variable_duration_unit function instead of convert_to_days#1154Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1154 +/- ##
==========================================
+ Coverage 87.35% 87.39% +0.03%
==========================================
Files 143 143
Lines 4135 4132 -3
==========================================
- Hits 3612 3611 -1
+ Misses 523 521 -2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@nnhjy your function does the same as the one I added before. So, I am reusing yours since it is better documented and to avoid having dirty hacks inside the functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing the function
align_variable_duration_unitinstead of creating a new oneconvert_to_daysFixes #1152
Checklist before merging