GH-1541 - Skip non-interfaces from Spring Data repository detection.

Author: odrotbohm

spring-modulith-core/src/main/java/org/springframework/modulith/core/Types.java

@@ -292,8 +292,9 @@ static boolean isPresent() {
 		}
 
 		static DescribedPredicate<JavaClass> isSpringDataRepository() {
-			return is(assignableTo(SpringDataTypes.REPOSITORY)) //
-					.or(isAnnotatedWith(SpringDataTypes.AT_REPOSITORY_DEFINITION));
+
+			return isInterface().and(is(assignableTo(SpringDataTypes.REPOSITORY)) //
+					.or(isAnnotatedWith(SpringDataTypes.AT_REPOSITORY_DEFINITION)));
 		}
 	}
 
@@ -321,4 +322,21 @@ public boolean test(JavaClass t) {
 			}
 		};
 	}
+
+	/**
+	 * A {@link DescribedPredicate} matching only interfaces.
+	 *
+	 * @return will never be {@literal null}.
+	 * @since 2.1, 2.0.3, 1.4.8
+	 */
+	static DescribedPredicate<JavaClass> isInterface() {
+
+		return new DescribedPredicate<>("is an interface") {
+
+			@Override
+			public boolean test(JavaClass t) {
+				return t.isInterface();
+			}
+		};
+	}
 }

spring-modulith-core/src/test/java/org/springframework/modulith/core/ArchitecturallyEvidentTypeUnitTest.java

@@ -107,7 +107,7 @@ void doesNotConsiderEntityAggregateRoot() {
 		assertThat(type.isAggregateRoot()).isFalse();
 	}
 
-	@Test
+	@Test // GH-1, GH-1541
 	void considersEntityAnAggregateRootIfTheresARepositoryForIt() {
 
 		Map<Class<?>, Boolean> parameters = new HashMap<Class<?>, Boolean>();
@@ -235,6 +235,9 @@ class SampleEntity {}
 
 	interface SampleRepository extends CrudRepository<SampleEntity, UUID> {}
 
+	// GH-1541
+	abstract class IntermediateImplementation implements CrudRepository<SampleEntity, UUID> {}
+
 	// GH-187
 	interface ReactiveSampleRepository extends ReactiveCrudRepository<SampleEntity, UUID> {}