Tests - Fix test entropy (#523)

* fix: loop sorted validator indexes

* generate JSON tests

* use generic sorting function

Author: MatheusFranco99

ssv/spectest/generate/tests/committee.MultiCommitteeSpecTest_decided.json

@@ -5,15 +5,15 @@
   "DutySlot": "12",
   "Input": "AQIDBAUGBwgJCgECAwQFBgcICQoBAgMEBQYHCAkKAQIAAAAAAAAAAAECAwQFBgcICQoBAgMEBQYHCAkKAQIDBAUGBwgJCgECAQAAAAAAAAABAgMEBQYHCAkKAQIDBAUGBwgJCgECAwQFBgcICQoBAg==",
   "SlashableSlots": {
-    "42409cb09fa945fa6a168cf8b0861045d6e562f211a70c4a1cdbcf0417898763": [
+    "5f4711a796c1116b5118ec35279fb64d551d9b38813d2939954dd2df5160d3d9": [
       "12"
     ]
   },
   "omitempty": [
-    "QkCcsJ+pRfpqFoz4sIYQRdblYvIRpwxKHNvPBBeJh2M=",
     "X0cRp5bBEWtRGOw1J5+2TVUdmziBPSk5lU3S31Fg09k=",
     "SOTAo46Q+TUtHQlIlEZEPr0XsZBPTwAC/olMLD9iRXo=",
-    "Zdx8F59oNHzxL4bhxR5U6K7u1XnUxxUIK7igOCwagVM="
+    "Zdx8F59oNHzxL4bhxR5U6K7u1XnUxxUIK7igOCwagVM=",
+    "QkCcsJ+pRfpqFoz4sIYQRdblYvIRpwxKHNvPBBeJh2M="
   ],
   "ExpectedError": "slashable attestation",
   "AnyError": false

ssv/spectest/generate/tests/committee.MultiCommitteeSpecTest_happy_flow.json

@@ -31,8 +31,8 @@ func MajoritySlashable() tests.SpecTest {
 	keySet := testingutils.Testing4SharesSet()
 	sharesPKBytes := make([]types.ShareValidatorPK, 0)
 	sharesPKString := make([]string, 0)
-	for _, shareKey := range keySet.Shares {
-		shareBytes := shareKey.Serialize()
+	for _, opShare := range testingutils.SortedMapKeys(keySet.Shares) {
+		shareBytes := opShare.Value.Serialize()
 		sharesPKBytes = append(sharesPKBytes, shareBytes)
 		sharesPKString = append(sharesPKString, hex.EncodeToString(shareBytes))
 	}

ssv/spectest/generate/tests/committee.MultiCommitteeSpecTest_start_committee_duty_with_missing_shares.json

@@ -31,8 +31,8 @@ func MinoritySlashable() tests.SpecTest {
 	keySet := testingutils.Testing4SharesSet()
 	sharesPKBytes := make([]types.ShareValidatorPK, 0)
 	sharesPKString := make([]string, 0)
-	for _, shareKey := range keySet.Shares {
-		shareBytes := shareKey.Serialize()
+	for _, opShare := range testingutils.SortedMapKeys(keySet.Shares) {
+		shareBytes := opShare.Value.Serialize()
 		sharesPKBytes = append(sharesPKBytes, shareBytes)
 		sharesPKString = append(sharesPKString, hex.EncodeToString(shareBytes))
 	}

ssv/spectest/generate/tests/tests.MultiMsgProcessingSpecTest_post_consensus_partial_invalid_root_quorum_then_valid_quorum.json

@@ -425,7 +425,8 @@ var TestingAttestationResponseBeaconObjectForDuty = func(ks *TestKeySet, version
 
 var TestingSignedAttestationSSZRootForKeyMap = func(ksMap map[phase0.ValidatorIndex]*TestKeySet) []string {
 	ret := make([]string, 0)
-	for _, ks := range ksMap {
+	for _, valKs := range SortedMapKeys(ksMap) {
+		ks := valKs.Value
 		duty := TestingAttesterDuty(spec.DataVersionPhase0).ValidatorDuties[0]
 		aggregationBitfield := bitfield.NewBitlist(duty.CommitteeLength)
 		aggregationBitfield.SetBitAt(duty.ValidatorCommitteeIndex, true)
@@ -440,8 +441,9 @@ var TestingSignedAttestationSSZRootForKeyMap = func(ksMap map[phase0.ValidatorIn
 
 var TestingElectraAttestationSSZRootForKeyMap = func(ksMap map[phase0.ValidatorIndex]*TestKeySet) []string {
 	ret := make([]string, 0)
-	for valIdx, ks := range ksMap {
-
+	for _, valKs := range SortedMapKeys(ksMap) {
+		ks := valKs.Value
+		valIdx := valKs.Key
 		committeeDuty := TestingAttesterDutyForValidator(spec.DataVersionElectra, valIdx)
 		duty := committeeDuty.ValidatorDuties[0]
 
@@ -467,8 +469,10 @@ var TestingElectraAttestationSSZRootForKeyMap = func(ksMap map[phase0.ValidatorI
 
 var TestingElectraSingleAttestationSSZRootForKeyMap = func(ksMap map[phase0.ValidatorIndex]*TestKeySet) []string {
 	ret := make([]string, 0)
-	for valIdx, ks := range ksMap {
 
+	for _, valKs := range SortedMapKeys(ksMap) {
+		ks := valKs.Value
+		valIdx := valKs.Key
 		committeeDuty := TestingAttesterDutyForValidator(spec.DataVersionElectra, valIdx)
 		duty := committeeDuty.ValidatorDuties[0]
 

ssv/spectest/generate/tests/tests.MultiMsgProcessingSpecTest_post_consensus_partial_invalid_sig_quorum_then_valid_quorum.json

@@ -38,7 +38,9 @@ var TestingSignedSyncCommitteeBlockRootForValidatorIndex = func(ks *TestKeySet,
 
 var TestingSignedSyncCommitteeBlockRootSSZRootForKeyMap = func(ksMap map[phase0.ValidatorIndex]*TestKeySet, version spec.DataVersion) []string {
 	ret := make([]string, 0)
-	for valIdx, ks := range ksMap {
+	for _, valKs := range SortedMapKeys(ksMap) {
+		ks := valKs.Value
+		valIdx := valKs.Key
 		ret = append(ret, GetSSZRootNoError(&altair.SyncCommitteeMessage{
 			Slot:            TestingDutySlotV(version),
 			BeaconBlockRoot: TestingBlockRoot,