Round number still set to 0 in some tests

[AgeManning]

Hey all,

We've run into more problems with round validation.

It seems this PR hasn't addressed all the tests.

Here are two examples:
https://github.com/ssvlabs/ssv-spec/blob/main/qbft/spectest/generate/tests/tests.CreateMsgSpecTest_qbft_create_message_create_round_change.json#L38

https://github.com/ssvlabs/ssv-spec/blob/main/qbft/spectest/generate/tests/tests.CreateMsgSpecTest_qbft_create_message_create_round_change_no_justification_quorum.json#L38

Is there a way we can check validation of types for most of the tests to try and catch all of these?

[AgeManning]

Should this be using the specific round number?
https://github.com/ssvlabs/ssv-spec/blob/main/qbft/spectest/tests/create_message_spectest.go#L152

[AgeManning]

For the QBFT create message, this is currently the result of our tests, so shows which have invalid round numbers:

✅ PASSED - Test 'create proposal not previously prepared'
test spec_tests::test_create_proposal_not_previously ... ok
✅ PASSED - Test 'create proposal previously prepared'

❌ FAILED - Test 'create round change no justification quorum'
   Rust hash: 638b2c59cf27107dfa725650a8766b97bc949edc9277b6ba3a6ae059fa1a9273
   Expected:  e26cab8b210008e410fbb09077c1310c4604a50f8a7b0e3746ef3cba7d625c39

🔍 KEY MISMATCHES DETECTED:
   📋 Structure: SignedSSVMessage → SSVMessage → QbftMessage
   ❌ QbftMessage.round: Rust=1 vs Go=0

❌ FAILED - Test 'create round change previously prepared'
   Rust hash: ae1c9309a4b87263ee85e9fcee32644c901f56cbc200dfd314d02515d7ceb68c
   Expected:  a6ffc48674f1522fb90aa7bde2aa76cac54480cf366cdd4afcd7f8b4d548809a

🔍 KEY MISMATCHES DETECTED:
   📋 Structure: SignedSSVMessage → SSVMessage → QbftMessage
   ❌ QbftMessage.round: Rust=1 vs Go=0
✅ PASSED - Test 'create proposal'

❌ FAILED - Test 'create round change'
   Rust hash: 762e29bc0e5d0cdf937ebb53d8fc9f4f0d07abedd80fbbc8295cdb9512bae959
   Expected:  a6ffc48674f1522fb90aa7bde2aa76cac54480cf366cdd4afcd7f8b4d548809a

🔍 KEY MISMATCHES DETECTED:
   📋 Structure: SignedSSVMessage → SSVMessage → QbftMessage
   ❌ QbftMessage.round: Rust=1 vs Go=0
✅ PASSED - Test 'create commit'
✅ PASSED - Test 'create proposal not previously prepared'
✅ PASSED - Test 'create prepare'

[alan-ssvlabs]

Hi! PR #554 is create to fix this problem. The problem are all from qbft create message spec tests and now a check for the round number is also added when running create message tests to ensure rounds are not 0.