Drive by: Unify checks for function call statements with expressions

Author: WardBrian

src/frontend/Typechecker.ml

@@ -914,13 +914,6 @@ let check_expression_of_scalar_or_type cf tenv t e name =
 
 (* -- Statements ------------------------------------------------- *)
 (* non returning functions *)
-let verify_nrfn_target loc cf id =
-  if
-    String.is_suffix id.name ~suffix:"_lp"
-    && not
-         (in_lp_function cf || cf.current_block = Model
-        || cf.current_block = TParam)
-  then Semantic_error.target_plusequals_outside_model_or_logprob loc |> error
 
 let check_nrfn loc tenv id es =
   match Env.find tenv id.name with
@@ -961,7 +954,9 @@ let check_nrfn loc tenv id es =
 let check_nr_fn_app loc cf tenv id es =
   let tes = List.map ~f:(check_expression cf tenv) es in
   verify_identifier id;
-  verify_nrfn_target loc cf id;
+  verify_fn_target_plus_equals cf loc id;
+  verify_fn_jacobian_plus_equals cf loc id;
+  verify_fn_rng cf loc id;
   check_nrfn loc tenv id tes
 
 (* target plus-equals / jacobian plus-equals *)

test/integration/bad/err-jacobian-plusequals-scope4.stan

@@ -0,0 +1,9 @@
+functions {
+  // void return type to check function statement, rather than expression
+  void foo_jacobian() {
+    jacobian += 1;
+  }
+}
+transformed data {
+  foo_jacobian();
+}

test/integration/bad/err_void_rng_check.stan

@@ -0,0 +1,9 @@
+functions {
+    void foo_rng(real x){
+        print(normal_rng(0,x));
+    }
+}
+
+model {
+    foo_rng(1.0);
+}

test/integration/bad/stanc.expected

@@ -1083,6 +1083,18 @@ Semantic error in 'err-jacobian-plusequals-scope3.stan', line 14, column 11 to c
     15:  }
    -------------------------------------------------
 
+The jacobian adjustment can only be applied in the transformed parameters block or in functions ending with _jacobian
+[exit 1]
+  $ ../../../../install/default/bin/stanc err-jacobian-plusequals-scope4.stan
+Semantic error in 'err-jacobian-plusequals-scope4.stan', line 8, column 2 to column 17:
+   -------------------------------------------------
+     6:  }
+     7:  transformed data {
+     8:    foo_jacobian();
+           ^
+     9:  }
+   -------------------------------------------------
+
 The jacobian adjustment can only be applied in the transformed parameters block or in functions ending with _jacobian
 [exit 1]
   $ ../../../../install/default/bin/stanc err-minus-types.stan
@@ -1245,6 +1257,18 @@ Syntax error in 'err-transformed-params.stan', line 4, column 0 to column 11, pa
    -------------------------------------------------
 
 "transformed parameters {", "model {" or "generated quantities {" expected after end of parameters block.
+[exit 1]
+  $ ../../../../install/default/bin/stanc err_void_rng_check.stan
+Semantic error in 'err_void_rng_check.stan', line 8, column 4 to column 17:
+   -------------------------------------------------
+     6:  
+     7:  model {
+     8:      foo_rng(1.0);
+             ^
+     9:  }
+   -------------------------------------------------
+
+Random number generators are only allowed in transformed data block, generated quantities block or user-defined functions with names ending in _rng.
 [exit 1]
   $ ../../../../install/default/bin/stanc expect_statement_seq_close_brace.stan
 Syntax error in 'expect_statement_seq_close_brace.stan', line 6, column 0 to column 0, parsing error:

test/integration/cli-args/warn-pedantic/stanc.expected

@@ -546,6 +546,10 @@ Warning in 'jacobian_warning_user.stan', line 5, column 2: Left-hand side of
     using jacobian += in the transformed parameters block.
 [exit 0]
   $ ../../../../../install/default/bin/stanc --warn-pedantic  lp_fun.stan
+Warning in 'lp_fun.stan', line 10, column 2: Using _lp functions in
+    transformed parameters is deprecated and will be disallowed in Stan 2.39.
+    Use an _jacobian function instead, as this allows change of variable
+    adjustments which are conditionally enabled by the algorithms.
 Warning: The parameter y has 2 priors.
 [exit 0]
   $ ../../../../../install/default/bin/stanc --warn-pedantic  missing-prior-false-alarm.stan

test/integration/good/pretty.expected

@@ -3991,6 +3991,10 @@ Warning in 'lp_transformed_param.stan', line 14, column 15: Using _lp
     functions in transformed parameters is deprecated and will be disallowed
     in Stan 2.39. Use an _jacobian function instead, as this allows change of
     variable adjustments which are conditionally enabled by the algorithms.
+Warning in 'lp_transformed_param.stan', line 15, column 2: Using _lp
+    functions in transformed parameters is deprecated and will be disallowed
+    in Stan 2.39. Use an _jacobian function instead, as this allows change of
+    variable adjustments which are conditionally enabled by the algorithms.
 [exit 0]
   $ ../../../../install/default/bin/stanc --auto-format map_rect.stan
 functions {