Merged
Conversation
Owner
|
Yeah there's some precedent for this kind of lint auto-fixer in conform alread. If it's something that people might want to add to their own configs if they're using oxlint in their projects, then it's something that's useful to include in the conform builtins. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure is this PR is acceptable, it runs the Oxlint linter with the --fix argument that applies automatic fixes : https://oxc.rs/docs/guide/usage/linter/automatic-fixes.html
I had to add it to my config to replicate the auto-fix from the eslint LS.
The config is also be customized to include other kind of fixes :
args = { "--fix-suggestions"}According to the documentation :
But as it is not really a formatter maybe it is out of scope?