Skip to content

Commit 929f4b1

Browse files
committed
fix: 修正一个页面变更导致的返回值节点获取失败
1 parent ffb6d72 commit 929f4b1

File tree

9 files changed

+30
-29
lines changed

9 files changed

+30
-29
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<!--Package Info-->
1111
<PropertyGroup>
12-
<VersionPrefix>1.2.2</VersionPrefix>
12+
<VersionPrefix>1.2.3</VersionPrefix>
1313

1414
<Description>a tool for generate and install Localized IntelliSense files. 用于生成和安装本地化IntelliSense文件的工具。</Description>
1515

src/IntelliSenseLocalizer.Core/IntelliSenseLocalizer.Core.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="BaseAnyEncoding" Version="1.0.1" />
9+
<PackageReference Include="BaseAnyEncoding" Version="1.0.3" />
1010
<PackageReference Include="Cuture.Http" Version="2.8.1" />
11-
<PackageReference Include="HtmlAgilityPack" Version="1.11.63" />
11+
<PackageReference Include="HtmlAgilityPack" Version="1.12.4" />
1212
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0" />
1313
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.1" />
1414
<PackageReference Include="System.IO.Hashing" Version="8.0.0" />

src/IntelliSenseLocalizer.Core/MSDocIntelliSenseItemUpdater.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ static IEnumerable<HtmlNode> FindNode(HtmlNode _htmlNode)
164164
return _htmlNode.SelectNodes(".//p")
165165
?? _htmlNode.SelectNodes(".//li")
166166
?? (_htmlNode.Name == "p" ? new[] { _htmlNode }.AsEnumerable() : null)
167-
?? new[] { HtmlNode.CreateNode("<p tags=\"emptyNode\" />") };
167+
?? [HtmlNode.CreateNode("<p tags=\"emptyNode\" />")];
168168
}
169169

170170
var contentLines = FindNode(htmlNode).Select(x => x.InnerHtml).ToArray();

src/IntelliSenseLocalizer.Core/Utils/MSDocPageAnalyser.cs

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public static MSDocPageAnalysisResult[] AnalysisHtmlDocument(string url, HtmlDoc
3838
var version = intelliSenseItems.First().IntelliSenseFileDescriptor.Moniker[^3..];
3939

4040
var memberRootNodes = htmlRootNode.SelectNodes("//div[@class=\"memberInfo\"]")?
41-
.Where(x => x.ParentNode.Attributes["data-moniker"].Value.Split(" ").Any(z => z.EndsWith(version)));
41+
.Where(x => x.ParentNode.Attributes["data-moniker"].Value.Split(" ").Any(z => z.EndsWith(version)));
4242
if (memberRootNodes?.Any() == true)
4343
{
4444
return memberRootNodes.Select(x =>
@@ -50,12 +50,13 @@ public static MSDocPageAnalysisResult[] AnalysisHtmlDocument(string url, HtmlDoc
5050
}).ToArray();
5151
}
5252

53-
var memberRootNode = htmlRootNode.SelectSingleNode("//div[@class=\"content \"]")?.SelectSingleNode(".//div[@class=\"summaryHolder\"]")?.ParentNode
54-
?? htmlRootNode.SelectSingleNode("//div[@class=\"content\"]")?.SelectSingleNode(".//div[@class=\"summaryHolder\"]")?.ParentNode
55-
?? htmlRootNode.SelectSingleNode("//div[@class=\"content \"]")
56-
?? htmlRootNode.SelectSingleNode("//div[@class=\"content\"]");
53+
//查找至少包含一个div子节点的 <div class="content"></div>
54+
var memberRootNode = htmlRootNode.SelectSingleNode("//div[@class=\"content \"][div]")?.SelectSingleNode(".//div[@class=\"summaryHolder\"]")?.ParentNode
55+
?? htmlRootNode.SelectSingleNode("//div[@class=\"content\"][div]")?.SelectSingleNode(".//div[@class=\"summaryHolder\"]")?.ParentNode
56+
?? htmlRootNode.SelectSingleNode("//div[@class=\"content \"][div]")
57+
?? htmlRootNode.SelectSingleNode("//div[@class=\"content\"][div]");
5758

58-
return new[] { CreatePageAnalysisResult(url, apiName, memberRootNode, intelliSenseItems) };
59+
return [CreatePageAnalysisResult(url, apiName, memberRootNode, intelliSenseItems)];
5960
}
6061
else
6162
{
@@ -142,13 +143,13 @@ private static MSDocPageAnalysisResult CreatePageAnalysisResult(string url, stri
142143

143144
if (currentGroupItem?.Element.GetReturnsNodes().Count > 0)
144145
{
145-
returnNode = htmlNode.SelectSingleNode("./dl[@class=\"propertyInfo\"]/following-sibling::p")
146+
returnNode = htmlNode.SelectSingleNode("./div[@class=\"propertyInfo\"]/following-sibling::p")
146147

147-
?? htmlNode.SelectNodes(".//h4")
148-
.ElementAtOrDefault(parameters.Any() ? 1 : 0)?
149-
.SelectSingleNode(".//following-sibling::p")
148+
?? htmlNode.SelectNodes(".//h4")
149+
.ElementAtOrDefault(parameters.Any() ? 1 : 0)?
150+
.SelectSingleNode(".//following-sibling::p")
150151

151-
?? HtmlNode.CreateNode("<p/>");
152+
?? HtmlNode.CreateNode("<p/>");
152153
}
153154

154155
return new MSDocPageAnalysisResult(url, uniqueKey, parameters, fields)

src/IntelliSenseLocalizer/Commands/Program.BuildCommand.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ internal partial class Program
5151

5252
private static Command BuildBuildCommand()
5353
{
54-
var packNameOption = new Option<string>(new[] { "-p", "--pack" }, Resources.StringCMDBuildOptionPackDescription);
55-
var monikerOption = new Option<string>(new[] { "-m", "--moniker" }, Resources.StringCMDBuildOptionMonikerDescription);
56-
var localeOption = new Option<string>(new[] { "-l", "--locale" }, () => LocalizerEnvironment.CurrentLocale, Resources.StringCMDBuildOptionLocaleDescription);
57-
var contentCompareTypeOption = new Option<ContentCompareType>(new[] { "-cc", "--content-compare" }, () => ContentCompareType.OriginFirst, Resources.StringCMDBuildOptionContentCompareDescription);
58-
var separateLineOption = new Option<string?>(new[] { "-sl", "--separate-line" }, Resources.StringCMDBuildOptionSeparateLineDescription);
59-
var outputOption = new Option<string>(new[] { "-o", "--output" }, () => LocalizerEnvironment.OutputRoot, Resources.StringCMDBuildOptionOutputDescription);
60-
var parallelCountOption = new Option<int>(new[] { "-pc", "--parallel-count" }, () => 2, Resources.StringCMDBuildOptionParallelCountDescription);
61-
var nocacheOption = new Option<bool>(new[] { "-nc", "--no-cache" }, () => false, Resources.StringCMDBuildOptionNoCacheDescription);
54+
var packNameOption = new Option<string>(["-p", "--pack"], Resources.StringCMDBuildOptionPackDescription);
55+
var monikerOption = new Option<string>(["-m", "--moniker"], Resources.StringCMDBuildOptionMonikerDescription);
56+
var localeOption = new Option<string>(["-l", "--locale"], () => LocalizerEnvironment.CurrentLocale, Resources.StringCMDBuildOptionLocaleDescription);
57+
var contentCompareTypeOption = new Option<ContentCompareType>(["-cc", "--content-compare"], () => ContentCompareType.OriginFirst, Resources.StringCMDBuildOptionContentCompareDescription);
58+
var separateLineOption = new Option<string?>(["-sl", "--separate-line"], Resources.StringCMDBuildOptionSeparateLineDescription);
59+
var outputOption = new Option<string>(["-o", "--output"], () => LocalizerEnvironment.OutputRoot, Resources.StringCMDBuildOptionOutputDescription);
60+
var parallelCountOption = new Option<int>(["-pc", "--parallel-count"], () => 2, Resources.StringCMDBuildOptionParallelCountDescription);
61+
var nocacheOption = new Option<bool>(["-nc", "--no-cache"], () => false, Resources.StringCMDBuildOptionNoCacheDescription);
6262

6363
var buildCommand = new Command("build", Resources.StringCMDBuildDescription)
6464
{

src/IntelliSenseLocalizer/Commands/Program.ShowCommand.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ private static Command BuildShowCommand()
1111
{
1212
var showCommand = new Command("show", Resources.StringCMDShowDescription);
1313

14-
var filterOption = new Option<string>(new[] { "-f", "--filter" }, Resources.StringOptionFilterDescription);
14+
var filterOption = new Option<string>(["-f", "--filter"], Resources.StringOptionFilterDescription);
1515

1616
{
1717
var showInstalledApplicationPacksCommand = new Command("packs", Resources.StringCMDShowPacksDescription)
@@ -25,8 +25,8 @@ private static Command BuildShowCommand()
2525
}
2626

2727
{
28-
var packNameOption = new Option<string>(new[] { "-p", "--pack" }, Resources.StringCMDShowOptionPackDescription);
29-
var monikerOption = new Option<string>(new[] { "-m", "--moniker" }, Resources.StringCMDShowOptionMonikerDescription);
28+
var packNameOption = new Option<string>(["-p", "--pack"], Resources.StringCMDShowOptionPackDescription);
29+
var monikerOption = new Option<string>(["-m", "--moniker"], Resources.StringCMDShowOptionMonikerDescription);
3030

3131
var showInstalledApplicationPackRefsCommand = new Command("refs", Resources.StringCMDShowPackRefsDescription)
3232
{

src/IntelliSenseLocalizer/Commands/Program.UnInstallCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ private static Command BuildUnInstallCommand()
1414
var uninstallCommand = new Command("uninstall", Resources.StringCMDUnInstallDescription);
1515
Argument<string> monikerArgument = new("moniker", Resources.StringCMDUnInstallArgumentMonikerDescription);
1616
Argument<string> localeArgument = new("locale", () => LocalizerEnvironment.CurrentLocale, Resources.StringCMDUnInstallArgumentLocaleDescription);
17-
Option<string> targetOption = new(new[] { "-t", "--target" }, () => LocalizerEnvironment.DefaultSdkRoot, Resources.StringCMDUnInstallOptionTargetDescription);
17+
Option<string> targetOption = new(["-t", "--target"], () => LocalizerEnvironment.DefaultSdkRoot, Resources.StringCMDUnInstallOptionTargetDescription);
1818

1919
uninstallCommand.Add(monikerArgument);
2020
uninstallCommand.Add(localeArgument);

src/IntelliSenseLocalizer/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ internal partial class Program
2020
{
2121
private static readonly LoggingLevelSwitch s_consoleLoggingLevelSwitch = new(LogEventLevel.Verbose);
2222

23-
private static readonly Option<int?> s_logLevelOption = new(new[] { "-ll", "--log-level" }, Resources.StringOptionLogLevelDescription);
23+
private static readonly Option<int?> s_logLevelOption = new(["-ll", "--log-level"], Resources.StringOptionLogLevelDescription);
2424

2525
private static Microsoft.Extensions.Logging.ILogger s_logger = null!;
2626

src/SimpleTranslateServer/SimpleTranslateServer.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
<ItemGroup Condition="'$(AotPublishing)' != 'true'">
1818
<PackageReference Include="Microsoft.AspNetCore.OpenApi" Version="8.0.*" />
19-
<PackageReference Include="SwaggerUI.AspNetCore" Version="5.29.0" />
19+
<PackageReference Include="SwaggerUI.AspNetCore" Version="5.29.4" />
2020
<PackageReference Include="Swashbuckle.AspNetCore.SwaggerGen" Version="6.6.2" />
2121
</ItemGroup>
2222

0 commit comments

Comments
 (0)