1.19.7: Example image "sewing threads" from heic.digital fails to decode with "Unspecified: Insufficient input data (2.0)"

[thiloplanz]

I get an error trying to read this HEIC sample image.

https://heic.digital/download-sample/sewing-threads.heic

https://heic.digital/samples/

$ magick -list format | grep HEIC
     HEIC  rw+   High Efficiency Image Format (1.19.7)

$ magick identify sewing-threads.heic 
identify: Invalid input: Unspecified: Insufficient input data (2.0) `sewing-threads.heic' @ error/heic.c/IsHEIFSuccess/203.

[bradh]

I'll do up a proper test and PR at some point, but if you want a quick fix, try:

diff --git a/libheif/file_layout.cc b/libheif/file_layout.cc
index 73bebd96..8f6c536a 100644
--- a/libheif/file_layout.cc
+++ b/libheif/file_layout.cc
@@ -102,7 +102,7 @@ Error FileLayout::read(const std::shared_ptr<StreamReader>& stream, const heif_s
       m_max_length = stream->request_range(next_box_start, next_box_header_end);
     }
 
-    if (next_box_header_end >= m_max_length) {
+    if (next_box_header_end > m_max_length) {
       return {heif_error_Invalid_input,
               heif_suberror_Unspecified,
               "Insufficient input data"};

Edit: Or just update, since it looks like Dirk already has the fix in...

[farindk]

@bradh Thanks, but I have just fixed this in 9839c99 a minute ago. It was due to the bad backported commit e2253ec for #1492.

[bradh]

Indeed, verified working for me.