Skip to content

fix(api): update rate limiters on hot config reload #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rooffeell wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −6
Open

fix(api): update rate limiters on hot config reload #2358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cmd/serve_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,8 @@ func serve(ctx context.Context) {
templatemailer.FromConfig(latestCfg, mrCache),
),

// Persist existing rate limiters.
//
// TODO(cstockton): we should consider updating these, if we
// rely on hot config reloads 100% then rate limiter changes
// won't be picked up.
limiterOpts,
// Update rate limiters based on new config.
api.NewLimiterOptions(latestCfg),
)
ah.Store(latestAPI)
}
Expand Down